对deps目标的link过程中丢失了参数，疑似bug，但是不确定，先请鉴定一下 #2572

augustheart · 2022-07-15T14:11:56Z

augustheart
Jul 15, 2022

我使用xmake重写soui的编译脚本过程中发现的，原项目比较复杂，不好直接提取。然后我按照原项目的结构写了个简单的编译，但是又没重现，因此虽然想提issue，但是发现自己没法提供准确的信息，无从下手。
我通过在xmake的脚本里面加print的方法找到的关键点比较令人迷惑。
原编译脚本，没写完，先写了个能编译的东西，有部分target略去了，主要是展示结构。我自己反复查看，没看出有啥问题

--set_project("soui4")
set_targetdir("bin")
add_defines("UNICODE","_UNICODE")
add_linkdirs("bin")
target("zlib")
    set_kind("static")
    add_includedirs("$(projectdir)/third-part/zlib",{public = true})
    add_files("$(projectdir)/third-part/zlib/*.c")
    set_prefixname("")
target_end()
target("png")
    add_deps("zlib")
    set_kind("static")
    add_includedirs("$(projectdir)/third-part/png",{public = true})
    add_files("$(projectdir)/third-part/png/*.c")
    set_prefixname("")
target_end()
target("utilities4")
    set_kind("shared")
    set_prefixname("")
    add_syslinks("user32","gdi32")
    add_defines("UTILITIES_EXPORTS")
    add_deps("png","zlib")
    add_includedirs("$(projectdir)/utilities/include",{public=true})
    add_files("$(projectdir)/utilities/src/**.cpp")
    if is_subhost("windows") then
        add_files("$(projectdir)/utilities/utilities.rc")
    else
        add_files("$(projectdir)/utilities/utilities_gcc.rc",{force={mrcflags="--codepage=936"}})
    end
    add_includedirs("$(projectdir)/utilities/include","$(projectdir)/config","$(projectdir)/utilities")
target_end()
target("soui")
    set_kind("shared")
    add_defines("SOUI_EXPORTS")
    add_deps("utilities4")
    add_includedirs("$(projectdir)/SOUI/include","$(projectdir)/config",{public=true})
    add_includedirs("$(projectdir)/SOUI")
    add_files("$(projectdir)/SOUI/src/**.cpp")
    set_prefixname("")
    add_syslinks("gdi32","shell32")
target_end()
target("demo")
    set_kind("binary")
    add_deps("soui","utilities4","wke","mhook","nanosvg","smiley","soui-sys-resource")
    add_includedirs("$(projectdir)/components","$(projectdir)/demo","$(projectdir)")
    add_files("$(projectdir)/demo/**.cpp","$(projectdir)/demo/*.rc")
    --add_syslinks("user32","gdi32")
target_end()

问题出在utilities4的编译上。如果

xmake b soui

或是直接

xmake b uilities4

是能够正常生成dll文件的。

[ 96%]: linking.release utilities4.dll
"C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Community\\VC\\Tools\\MSVC\\14.29.30133\\bin\\HostX64\\x64\\link.exe" -dll -nologo -machine:x64 -libpath:bin png.lib zlib.lib user32.lib gdi32.lib -out:bin\utilities4.dll build\.objs\utilities4

但是如果

xmake b demo

问题就出现了

[ 96%]: linking.release utilities4.dll
"C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Community\\VC\\Tools\\MSVC\\14.29.30133\\bin\\HostX64\\x64\\link.exe" -dll -nologo -machine:x64 -out:bin\utilities4.dll build\.objs\utilities4\windows\x64\release\utilities\src\gdialpha.cpp.obj build\.objs\utilities4\windows\x64\release\utilities\src\helper\SAutoBuf.cpp.obj build\.objs\utilities4\windows\x64\release\utilities\src\helper\SCriticalSection.cpp.obj build\.objs\utilities4\windows\x64\release\utilities\src\helper\SSemaphore.cpp.obj build\.objs\utilities4\windows\x64\release\utilities\src\pugixml\pugixml.cpp.obj build\.objs\utilities4\windows\x64\release\utilities\src\soui_mem_wrapper.cpp.obj build\.objs\utilities4\windows\x64\release\utilities\src\string\sstringa.cpp.obj build\.objs\utilities4\windows\x64\release\utilities\src\string\sstringdata.cpp.obj build\.objs\utilities4\windows\x64\release\utilities\src\string\sstringw.cpp.obj build\.objs\utilities4\windows\x64\release\utilities\src\string\strcpcvt.cpp.obj build\.objs\utilities4\windows\x64\release\utilities\src\trace.cpp.obj build\.objs\utilities4\windows\x64\release\utilities\src\utilities.cpp.obj build\.objs\utilities4\windows\x64\release\utilities\src\xml\SXml.cpp.obj build\.objs\utilities4\windows\x64\release\utilities\utilities.rc.obj
error: @programdir\modules\private\async\runjobs.lua:256: @programdir\actions\build\kinds\shared.lua:89: @programdir\modules\core\tools\link.lua:159: gdialpha.cpp.obj : error LNK2019: 无法解析的外部符号 __imp_GetCurrentObject，函数 "public: static int __cdecl SOUI::CGdiAlpha::AlphaBackup(struct HDC__ *,struct tagRECT const *,struct SOUI::tagALPHAINFO &)" (?AlphaBackup@CGdiAlpha@SOUI@@SAHPEAUHDC__@@PEBUtagRECT@@AEAUtagALPHAINFO@2@@Z) 中引用了该符号
gdialpha.cpp.obj : error LNK2019: 无法解析的外部符号 __imp_GetViewportOrgEx，函数 "public: static int __cdecl SOUI::CGdiAlpha::AlphaBackup(struct HDC__ *,struct tagRECT const *,struct SOUI::tagALPHAINFO &)" (?AlphaBackup@CGdiAlpha@SOUI@@SAHPEAUHDC__@@PEBUtagRECT@@AEAUtagALPHAINFO@2@@Z) 中引用了该符号
gdialpha.cpp.obj : error LNK2019: 无法解析的外部符号 __imp_GetObjectW，函数 "public: static int __cdecl SOUI::CGdiAlpha::AlphaBackup(struct HDC__ *,struct tagRECT const *,struct SOUI::tagALPHAINFO &)" (?AlphaBackup@CGdiAlpha@SOUI@@SAHPEAUHDC__@@PEBUtagRECT@@AEAUtagALPHAINFO@2@@Z) 中引用了该符号
ha::AlphaBackup(struct HDC__ *,struct tagRECT const *,struct SOUI::tagALPHAINFO &)" (?AlphaBackup@CGdiAlpha@SOUI@@SAHPEAUHDC__@@PEBUtagRECT@@AEAUtagALPHAINFO@2@@Z) 中引用了该符号
gdialpha.cpp.obj : error LNK2019: 无法解析的外部符号 __imp_OffsetRect，函数 "public: static int __cdecl SOUI::CGdiAlpha::AlphaBackup(struct HDC__ *,struct tagRECT const *,struct SOUI::tagALPHAINFO &)" (?AlphaBackup@CGdiAlpha@SOUI@@SAHPEAUHDC__@@PEBUtagRECT@@AEAUtagALPHAINFO@2@@Z) 中引用了该符号
sstringa.cpp.obj : error LNK2019: 无法解析的外部符号 __imp_LoadStringA，函数 "public: static int __cdecl SOUI::char_traits::LoadStringW(struct HINSTANCE__ *,unsigned int,char *,int)" (?LoadStringW@char_traits@SOUI@@SAHPEAUHINSTANCE__@@IPEADH@Z) 中引用了该符号
sstringw.cpp.obj : error LNK2019: 无法解析的外部符号 __imp_LoadStringW，函数 "public: static int __cdecl SOUI::wchar_traits::LoadStringW(struct HINSTANCE__ *,unsigned int,wchar_t *,int)" (?LoadStringW@wchar_traits@SOUI@@SAHPEAUHINSTANCE__@@IPEA_WH@Z) 中引用了该符号
utilities.cpp.obj : error LNK2019: 无法解析的外部符号 __imp_GetDeviceCaps，函数 "void __cdecl SOUI::SHiMetricToPixel(struct tagSIZE const *,struct tagSIZE *)" (?SHiMetricToPixel@SOUI@@YAXPEBUtagSIZE@@PEAU2@@Z) 中引用了该符号
utilities.cpp.obj : error LNK2019: 无法解析的外部符号 __imp_GetDC，函数 "void __cdecl SOUI::SHiMetricToPixel(struct tagSIZE const *,struct tagSIZE *)" (?SHiMetricToPixel@SOUI@@YAXPEBUtagSIZE@@PEAU2@@Z) 中引用了该符号
utilities.cpp.obj : error LNK2019: 无法解析的外部符号 __imp_ReleaseDC，函数 "void __cdecl SOUI::SHiMetricToPixel(struct tagSIZE const *,struct tagSIZE *)" (?SHiMetricToPixel@SOUI@@YAXPEBUtagSIZE@@PEAU2@@Z) 中引用了该符号
bin\utilities4.dll : fatal error LNK1120: 10 个无法解析的外部命令

stack traceback:
    [C]: in function 'error'
    [@programdir\core\base\os.lua:872]:
    [@programdir\modules\core\tools\link.lua:159]: in function 'catch'
    [@programdir\core\sandbox\modules\try.lua:127]: in function 'try'
    [@programdir\modules\core\tools\link.lua:139]:
    [C]: in function 'xpcall'
    [@programdir\core\base\utils.lua:280]:
    [@programdir\actions\build\kinds\shared.lua:89]: in function 'callback'
    [@programdir\modules\core\project\depend.lua:189]: in function 'on_changed'
    [@programdir\actions\build\kinds\shared.lua:55]: in function '_do_link_target'
    [@programdir\actions\build\kinds\shared.lua:117]:
    [@programdir\actions\build\kinds\shared.lua:153]: in function '_link_target'
    [@programdir\actions\build\kinds\shared.lua:184]: in function 'jobfunc'
    [@programdir\modules\private\async\runjobs.lua:232]:
    [C]: in function 'xpcall'
    [@programdir\core\base\utils.lua:280]: in function 'trycall'
    [@programdir\core\sandbox\modules\try.lua:121]: in function 'try'
    [@programdir\modules\private\async\runjobs.lua:218]: in function 'cotask'
    [@programdir\core\base\scheduler.lua:388]:

stack traceback:
        [C]: in function 'error'
        @programdir\core\base\os.lua:872: in function 'os.raiselevel'
        (...tail calls...)
        @programdir\modules\private\async\runjobs.lua:256: in field 'catch'
        @programdir\core\sandbox\modules\try.lua:127: in global 'try'
        @programdir\modules\private\async\runjobs.lua:218: in upvalue 'cotask'
        @programdir\core\base\scheduler.lua:388: in function <@programdir\core\base\scheduler.lua:385>

注意到，两次编译的命令中，错误的部分少了参数。

-libpath:bin png.lib zlib.lib user32.lib gdi32.lib

我反复验证和查看文档，没发现自己的配置写法有任何问题。所以我最后开始在lua文件里面添加prinf来查看问题。
我沿着调用栈一层层地往上查，在关键的target处打印日志：

print("target: " .. target:name())
for k,v in pairs(target:linkflags())do
print("k:"..k .. ",v:" .. tostring(v))
end

最后跟踪到文件\actions\build\kinds\shared.lua
当我在函数
function _link_target(target, opt)
开始添加上述代码时，
输出为：

checking for the static library archiver (ar) ... link.exe
target: main:utilities4
k:1,v:-nologo
k:2,v:-machine:x64

可以看到，这里的参数已经缺失了。编译结果毫不意外地报告缺少符号。
然后我把代码再移到上一层调用，到了function main(batchjobs, rootjob, target)，修改后的代码如下：

-- add batch jobs for building shared target
function main(batchjobs, rootjob, target)
print("target: main:" .. target:name())
for k,v in pairs(target:linkflags())do
print("k:"..k .. ",v:" .. tostring(v))
end
    -- add link job
    local job_link = batchjobs:addjob(target:name() .. "/link", function (index, total)
        _link_target(target, {progress = (index * 100) / total})
    end, {rootjob = rootjob})

神奇的情况出现了，utlities4.dll居然正常编译通过

PS G:\Project\Code\MyProject\soui4> xmake b -vD demo
target: main:soui
k:1,v:-nologo
k:2,v:-machine:x64
k:3,v:-libpath:bin
k:4,v:utilities4.lib
k:5,v:png.lib
k:6,v:zlib.lib
k:7,v:gdi32.lib
k:8,v:shell32.lib
target: main:utilities4
k:1,v:-nologo
k:2,v:-machine:x64
k:3,v:-libpath:bin
k:4,v:png.lib
k:5,v:zlib.lib
k:6,v:user32.lib
k:7,v:gdi32.lib
target: main:soui-sys-resource
k:1,v:-nologo
k:2,v:-machine:x64
k:3,v:-libpath:bin
k:4,v:/NOENTRY
[  9%]: compiling.release soui-sys-resource\soui-sys-resource.rc
"C:\\Program Files (x86)\\Windows Kits\\10\\bin\\10.0.19041.0\\x64\\rc.exe" -nologo -DUNICODE -D_UNICODE -IG:\Project\Code\MyProject\soui4/soui-sys-resource -Fobuild\.objs\soui-sys-resource\windows\x64\release\soui-sys-resource\soui-sys-resource.rc.obj soui-sys-resource\soui-sys-resource.rc
[  9%]: compiling.release demo\demo.rc
"C:\\Program Files (x86)\\Windows Kits\\10\\bin\\10.0.19041.0\\x64\\rc.exe" -nologo -DUNICODE -D_UNICODE -IG:\Project\Code\MyProject\soui4/components -IG:\Project\Code\MyProject\soui4/demo -IG:\Project\Code\MyProject\soui4 -IG:\Project\Code\MyProject\soui4/soui-sys-resource -IG:\Project\Code\MyProject\soui4/controls.extend/smiley -IG:\Project\Code\MyProject\soui4/third-part/nanosvg/src -IG:\Project\Code\MyProject\soui4/third-part/mhook/mhook-lib -IG:\Project\Code\MyProject\soui4/third-part/wke/include -IG:\Project\Code\MyProject\soui4/SOUI/include -IG:\Project\Code\MyProject\soui4/config -IG:\Project\Code\MyProject\soui4/utilities/include -IG:\Project\Code\MyProject\soui4/third-part/png -IG:\Project\Code\MyProject\soui4/third-part/zlib -Fobuild\.objs\demo\windows\x64\release\demo\demo.rc.obj demo\demo.rc
[ 32%]: compiling.release utilities\utilities.rc
"C:\\Program Files (x86)\\Windows Kits\\10\\bin\\10.0.19041.0\\x64\\rc.exe" -nologo -DUNICODE -D_UNICODE -DUTILITIES_EXPORTS -IG:\Project\Code\MyProject\soui4/utilities/include -IG:\Project\Code\MyProject\soui4/config -IG:\Project\Code\MyProject\soui4/utilities -IG:\Project\Code\MyProject\soui4/third-part/png -IG:\Project\Code\MyProject\soui4/third-part/zlib -Fobuild\.objs\utilities4\windows\x64\release\utilities\utilities.rc.obj utilities\utilities.rc
[ 92%]: linking.release soui-sys-resource.dll
"C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Community\\VC\\Tools\\MSVC\\14.29.30133\\bin\\HostX64\\x64\\link.exe" -dll -nologo -machine:x64 -libpath:bin /NOENTRY -out:bin\soui-sys-resource.dll build\.objs\soui-sys-resource\windows\x64\release\soui-sys-resource\soui-sys-resource.rc.obj
[ 96%]: linking.release utilities4.dll
"C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Community\\VC\\Tools\\MSVC\\14.29.30133\\bin\\HostX64\\x64\\link.exe" -dll -nologo -machine:x64 -libpath:bin png.lib zlib.lib user32.lib gdi32.lib -out:bin\utilities4.dll build\.objs\utilities4\windows\x64\release\utilities\src\gdialpha.cpp.obj build\.objs\utilities4\windows\x64\release\utilities\src\helper\SAutoBuf.cpp.obj build\.objs\utilities4\windows\x64\release\utilities\src\helper\SCriticalSection.cpp.obj build\.objs\utilities4\windows\x64\release\utilities\src\helper\SSemaphore.cpp.obj build\.objs\utilities4\windows\x64\release\utilities\src\pugixml\pugixml.cpp.obj build\.objs\utilities4\windows\x64\release\utilities\src\soui_mem_wrapper.cpp.obj build\.objs\utilities4\windows\x64\release\utilities\src\string\sstringa.cpp.obj build\.objs\utilities4\windows\x64\release\utilities\src\string\sstringdata.cpp.obj build\.objs\utilities4\windows\x64\release\utilities\src\string\sstringw.cpp.obj build\.objs\utilities4\windows\x64\release\utilities\src\string\strcpcvt.cpp.obj build\.objs\utilities4\windows\x64\release\utilities\src\trace.cpp.obj build\.objs\utilities4\windows\x64\release\utilities\src\utilities.cpp.obj build\.objs\utilities4\windows\x64\release\utilities\src\xml\SXml.cpp.obj build\.objs\utilities4\windows\x64\release\utilities\utilities.rc.obj
[ 98%]: linking.release demo.exe

编译脚本没写完，所以demo的编译是失败的。但是可以看到，utilities4的编译居然正常了。
而你可以看到，我添加的输出代码不会修改任何值，但是最终却产生了预期之外的变化。上面这个情况不是偶发，我从前天到今天测了三个晚上，稳定重现。
版本：
xmake v2.6.8+HEAD.e18471251, A cross-platform build utility based on Lua
如果可以的话，我可以按这个提一个issue，但是目前按照原项目的结构没捣鼓出一个可重现的例子，这个issue就比较艰难了。

Smalldy · 2022-07-24T02:24:53Z

Smalldy
Jul 24, 2022

你这个也太邪门了吧

2 replies

waruqi Jul 24, 2022
Maintainer

上面那个 xmake.lua 能复现出问题么？可以提个 issues 过来，如果能复现最好了，方便这边调试分析下。

StarBeat Sep 10, 2023

我貌似也遇到了类似问题，so 编译连接不报错，执行文件链接报错， xrepo info 看其中一个package fetchinfo 没有 linkdirs libfiles 信息，只有 sysincludedirs version 和 shared

augustheart · 2024-07-19T15:36:41Z

augustheart
Jul 19, 2024
Author

多年后的回复，已经修正！！
#5361

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

对deps目标的link过程中丢失了参数，疑似bug，但是不确定，先请鉴定一下 #2572

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Replies: 2 comments 2 replies

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

Select a reply

对deps目标的link过程中丢失了参数，疑似bug，但是不确定，先请鉴定一下 #2572

augustheart Jul 15, 2022

Replies: 2 comments · 2 replies

Smalldy Jul 24, 2022

waruqi Jul 24, 2022 Maintainer

StarBeat Sep 10, 2023

augustheart Jul 19, 2024 Author

augustheart
Jul 15, 2022

Replies: 2 comments 2 replies

Smalldy
Jul 24, 2022

waruqi Jul 24, 2022
Maintainer

augustheart
Jul 19, 2024
Author