-
-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JS components are no longer exported. only TS components work. #420
Comments
Same here - any known workarounds? |
Are you talking about the NPM version or the current master? If it’s the latest do you know which commit breaks js component? |
You can use my branch but there is probably another way. I got all of JS components working, but it seems hacky.
…Sent from my iPhone
On Sep 9, 2019, at 1:59 PM, Quentin Valmori ***@***.***> wrote:
Are you talking about the NPM version or the current master? If it’s the latest do you know which commit breaks js component?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Index.ts doest export any JS components. Also the TS compiler needs to be called with the flag to copy over the JS files from src to lib.
…Sent from my iPhone
On Sep 9, 2019, at 1:59 PM, Quentin Valmori ***@***.***> wrote:
Are you talking about the NPM version or the current master? If it’s the latest do you know which commit breaks js component?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
So this is an update of the TS compiler that cause this issue? Where can I find your branch? |
Specifically this branch, not master https://github.com/siderakis/react-native-material-kit/tree/master-siderakis
I ended up checking in the /lib directory but that might not be needed. Just updating index.ts to export the JS components and calling the TS compiler with the flag to copy the JS files to lib might work.
…Sent from my iPhone
On Sep 10, 2019, at 11:34 AM, Christopher Novak ***@***.***> wrote:
This is his branch. I'm experiencing this issue on RN 0.61.0-rc.2
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: