Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with datetime objects (old impl) #338

Closed
wants to merge 1 commit into from

Conversation

Endogen
Copy link
Contributor

@Endogen Endogen commented Dec 10, 2024

Description

I previously replaced Datetime._from_datetime(datetime.now()) with datetime.now() but that was a mistake. It's not the same because the previous code uses our own Datetime object from the time module and that's needed.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have performed a self-review of my own code
  • I have tested this change in my development environment.
  • I have added tests to prove that this change works
  • All existing tests pass after this change
  • I have added / updated documentation related to this change

@Endogen
Copy link
Contributor Author

Endogen commented Dec 12, 2024

Not needed anymore since we are not using this old impl anymore

@Endogen Endogen closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant