Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs? #9

Open
ryukinix opened this issue Feb 1, 2018 · 6 comments
Open

Docs? #9

ryukinix opened this issue Feb 1, 2018 · 6 comments
Labels

Comments

@ryukinix
Copy link
Member

ryukinix commented Feb 1, 2018

I'd love to read docs about that :)

@little-dude
Copy link
Collaborator

Good (and embarrassing) point. I'll have some time to do this this week-end probably.

@ryukinix
Copy link
Member Author

ryukinix commented Feb 1, 2018

Thanks for your attention on that, would really help me on a personal project.

@ryukinix ryukinix added the docs label Mar 8, 2018
@Cogitri
Copy link
Collaborator

Cogitri commented Jun 13, 2019

I'll work on this this evening, I suppose (at least for the client part, I don't quite get the futures related stuff yet, I suppose, I really have to plow through tokio's docs) :)

@little-dude
Copy link
Collaborator

@Cogitri maybe you should wait before I finish #31

I noticed a pretty horrible thing while working on the PR that I'm planning to address soon: in spawn I actually create an event loop to run the RPC endoing (see https://github.com/xi-frontend/xrl/blob/master/src/core.rs#L79). This is bad because users want to use their own executor for this. For instance, in xi-term we also create a tokio executor with tokio::run so we end up with two: one for the RPC endpoint, one for the TUI.

@Cogitri
Copy link
Collaborator

Cogitri commented Jun 13, 2019

Ah, alright. One thing I've noticed: When I don't start a 3rd event loop for logging to core stderr I get even more oddities, I'll open another issue about that.

@ryukinix
Copy link
Member Author

Good to see progress on that! Thanks for giving attention to this :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants