You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is this bug fix critical for your commercial enterprise?
We will contact you.
Describe the bug
The html2canvas part of the getSnapshot function appends generated canvases to document.body when the plugins' canvases aren't contained there.
This leads to the html2canvas function throwing a taint warning/error and the tag to grow every time getSnapshot is called. These generated canvases aren't cleaned up either.
To Reproduce
Steps to reproduce the behavior:
Don't keep the canvases for the viewer and the plugins in the tag - we've put them inside a Vue JS 3 app, so like three
deep.
Use StoreyViewsPlugin, NavCubePlugin, AxisGizmoPlugin, SectionPlanesPlugin, DistanceMeasurementsPlugin plugins.
Load in a file with IfcBuildingStorey objects
Call StoreyViewsPlugin.createStoreyMap()
Commenting out the html2canvas loop in getSnapshot makes it behave as expected.
Expected behavior
No warnings/errors concerning canvas taint in the console output.
Document.body is never messed with, and especially is never left with garbage canvases.
We don't want to show the other plugins in the storey map, so this feature should be avoidable via config.
Screenshots
n/a
Desktop (please complete the following information):
OS: Win 11
Browser: Chrome
Version: 131.0.6778.86
Smartphone (please complete the following information):
n/a
Additional context
n/a
The text was updated successfully, but these errors were encountered:
Is this bug fix critical for your commercial enterprise?
We will contact you.
Describe the bug
The html2canvas part of the getSnapshot function appends generated canvases to document.body when the plugins' canvases aren't contained there.
This leads to the html2canvas function throwing a taint warning/error and the tag to grow every time getSnapshot is called. These generated canvases aren't cleaned up either.
To Reproduce
Steps to reproduce the behavior:
Commenting out the html2canvas loop in getSnapshot makes it behave as expected.
Expected behavior
No warnings/errors concerning canvas taint in the console output.
Document.body is never messed with, and especially is never left with garbage canvases.
We don't want to show the other plugins in the storey map, so this feature should be avoidable via config.
Screenshots
n/a
Desktop (please complete the following information):
Smartphone (please complete the following information):
n/a
Additional context
n/a
The text was updated successfully, but these errors were encountered: