Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the application #399

Closed
rijnhard opened this issue Jul 30, 2024 · 21 comments
Closed

Rename the application #399

rijnhard opened this issue Jul 30, 2024 · 21 comments
Labels
enhancement New feature or request flatpak Related to flatpak package snap Related to snap package

Comments

@rijnhard
Copy link

Description
The app has been delisted from Flathub

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'flathub'
  2. See the error

Expected behavior
Should not be delisted

Screenshots
Screenshot

Environment

  • Distro: Fedora 40 (KDE)
  • Package: flatpak (flathub)
  • Desktop Environment: KDE
@rijnhard rijnhard added the bug Something isn't working label Jul 30, 2024
@Pryka
Copy link

Pryka commented Jul 30, 2024

It won't come back unless some changes are made - flathub/com.github.eneshecan.WhatsAppForLinux#14

@winstonma
Copy link

Does it mean that the name of the app need to be changed in order to get back to flathub?

@James-Oakley
Copy link

Looking at the linked issue, I can see that @eneshecan doesn't wish to rename the app. I'm wondering why renaming it is so bad that delisting would be preferred.

@goldyfruit
Copy link

On my side, if the application is not listed on Flathub then I'm not gonna use it anymore (which will be a shame).

@xeco23
Copy link
Owner

xeco23 commented Aug 1, 2024

I am not completely against renaming but it needs a bit of time and effort which I don't have these days. Yet I am also unable to come up with a good name. If you guys can propose a good name, we can rename it :) After that, it would be nice to have someone maintaining the flatpak package again.

@xeco23 xeco23 added the flatpak Related to flatpak package label Aug 1, 2024
@rijnhard
Copy link
Author

rijnhard commented Aug 2, 2024 via email

@colonia-duck
Copy link

I second the name 'Portal for WhatsApp'.

@xeco23
Copy link
Owner

xeco23 commented Sep 16, 2024

I second the name 'Portal for WhatsApp'.

Well, I think this also goes against the naming policy of flatpak since it includes WhatsApp. We need something more creative.

@colonia-duck
Copy link

Well, I think this also goes against the naming policy of flatpak since it includes WhatsApp. We need something more creative.

ah yes that maybe a problem.

@rijnhard
Copy link
Author

@bbhtt @barthalion would "Portal for WhatsApp" be acceptable?

@bbhtt
Copy link

bbhtt commented Sep 17, 2024

Yes that's fine although preferably you can come up with your own distinct name like Whatsie or Youp which would be even better.

The other issue is having its own distinct icon https://raw.githubusercontent.com/eneshecan/whatsapp-for-linux/master/resource/image/icons/hicolor/256x256/apps/com.github.eneshecan.WhatsAppForLinux.png looks like a recoloured version of the official icon.

See the icon included in https://about.meta.com/brand/resources/whatsapp/whatsapp-brand/ -> Glyph -> Digital -> SVG -> Green for comparison.

@stklcode
Copy link

stklcode commented Oct 7, 2024

Suggestion: Rebuild a balloon out of two simple shapes and add a keyboard instead of phone icon (the "app" is designed to use on computers, not phones) and keep the green:

icon icon icon icon-attention icon-attention icon-attention

I don't really like the pale color (but that's personal taste), so maybe switch LimeGreen ...

icon-attention icon-attention icon-attention icon icon icon

For reference, the original WhatsApp logo a same scale

WhatsApp WhatsApp WhatsApp

Feel free to use either (of the custom versions of course) at project license. I can push a PR replacing the current PNG version if desired.

(I am neither a designer nor a trademarks expert, just an attempt to maybe get some movement in here)

@rijnhard
Copy link
Author

rijnhard commented Oct 9, 2024

Re the name, just to avoid containing WhatsApp.

  • WhatUp
  • ChatUp
  • GreenUp
  • WA Desktop
  • at this point I'm just dumping bad names 😅

I think is @eneshecan is fine with living in the grey area then Portal for WhatsApp with the new icon.

And we ready to rock.

@eylenburg
Copy link

Would another alternative be to host a Flatpak "repo" (with just 1 app) yourself? It would still be useful for people on Flatpak-first systems like Fedora Atomic or OpenSUSE MicroOS.

@stklcode
Copy link

No capacity to change the name, but host another repo... 🤔

Besides that, the actual issue is trademark rights / usage terms of the name WhatsApp and logo and this would apply if hosted on a different repository, just shifts the accountability.

@xeco23
Copy link
Owner

xeco23 commented Oct 17, 2024

Okay, I renamed the app to WasIstLos since I didn't want to wait anymore, and it had been in my mind for quite a while. Please consider reporting some forgotten things or creating a PR.

Anyone is welcome to submit a flatpak repo and maintain it. Please refer to the old repo: https://github.com/flathub/com.github.eneshecan.WhatsAppForLinux.

@xeco23
Copy link
Owner

xeco23 commented Oct 17, 2024

Suggestion: Rebuild a balloon out of two simple shapes and add a keyboard instead of phone icon (the "app" is designed to use on computers, not phones) and keep the green:
icon icon icon icon-attention icon-attention icon-attention

I don't really like the pale color (but that's personal taste), so maybe switch LimeGreen ...
icon-attention icon-attention icon-attention icon icon icon

For reference, the original WhatsApp logo a same scale
WhatsApp WhatsApp WhatsApp

Feel free to use either (of the custom versions of course) at project license. I can push a PR replacing the current PNG version if desired.

(I am neither a designer nor a trademarks expert, just an attempt to maybe get some movement in here)

Thanks a lot! I will replace the icons soon, but still, please feel free to create a PR.

@xeco23 xeco23 changed the title Delisted from Flathub Rename the application Oct 17, 2024
@xeco23 xeco23 added snap Related to snap package enhancement New feature or request and removed bug Something isn't working labels Oct 17, 2024
@xeco23 xeco23 pinned this issue Oct 18, 2024
@xeco23
Copy link
Owner

xeco23 commented Oct 19, 2024

Atm snap and flatpak packages redirect to non-existent links. I'll create a new release soon with the new name. Then, the existing packages should slowly switch to that. I will take care of the snap migration but as said will not do anything about the flatpak. A new maintainer for the flatpak package is much appreciated.

@xeco23
Copy link
Owner

xeco23 commented Oct 19, 2024

I also decided to stop maintaining snap because it's driving me mad...

@colonia-duck
Copy link

fair enough.
I've migrated the Gentoo package to the new name.

ivan-hc added a commit to ivan-hc/AM that referenced this issue Oct 31, 2024
@bbhtt
Copy link

bbhtt commented Jan 18, 2025

Anyone is welcome to submit a flatpak repo and maintain it. Please refer to the old repo: https://github.com/flathub/com.github.eneshecan.WhatsAppForLinux.

A new submission for Flathub is not needed. The ID is a technical detail and doesn't need to change. Only the user visible parts need to change name in metainfo, desktop file, icon etc. So resubmission is not needed.

Updating the old one to the new branding is enough. If anyone wants to do it, please open an issue on https://github.com/flathub/flathub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request flatpak Related to flatpak package snap Related to snap package
Projects
None yet
Development

No branches or pull requests

10 participants