Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve types for Modal #311

Open
scrymetto opened this issue Jan 13, 2021 · 0 comments
Open

Improve types for Modal #311

scrymetto opened this issue Jan 13, 2021 · 0 comments

Comments

@scrymetto
Copy link
Contributor

Now you can't extends IModal and use it for better typing when you use getModalByName selector, because all additional fields throw error TS2741 Property is missing in type IModal but required in type IExtendModal. In case you use IModal, all fields except isOpen have any type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant