Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Use Dict for type annotation in PHASE_REPORT_KEY for better compatibility #269

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: Use Dict for type annotation in PHASE_REPORT_KEY for better compatibility #269

wants to merge 1 commit into from

Conversation

rushikeshjadhav
Copy link

@rushikeshjadhav rushikeshjadhav commented Jan 30, 2025 •
edited
Loading

@stormi
Copy link
Member

stormi commented Feb 3, 2025

Use Dict for type annotation in PHASE_REPORT_KEY for better compatibility

Let's make it a separate PR.

@rushikeshjadhav rushikeshjadhav changed the title storage/linstor: Add provisioning type support and multi-disk enhancements for Linstor SR tests refactor: Use Dict for type annotation in PHASE_REPORT_KEY for better compatibility Feb 5, 2025
@rushikeshjadhav
Copy link
Author

Use Dict for type annotation in PHASE_REPORT_KEY for better compatibility

Let's make it a separate PR.

Amended this PR.

@rushikeshjadhav rushikeshjadhav marked this pull request as ready for review February 5, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to run pytest with platform linux -- Python 3.8.13, pytest-8.3.4, pluggy-1.5.0
2 participants
@rushikeshjadhav @stormi