Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComputedSet inspiration fragments are lost when loader is run #42

Open
reskyner opened this issue Jul 28, 2020 · 2 comments
Open

ComputedSet inspiration fragments are lost when loader is run #42

reskyner opened this issue Jul 28, 2020 · 2 comments

Comments

@reskyner
Copy link
Contributor

When the loader is run to update the data for an existing target, the links to inspiration fragments in the ComputedMolecule computed_inspirations field are lost.

Potential solution

  1. When updating the data, for each compound, find its relevant id in the Molecule table (potential problem when compounds are renamed)
  2. When updating the specific compound, swap out the old id for the new id in the computed_inspirations field
@duncanpeacock
Copy link

This problem re-occurred during testing of: (m2ms/fragalysis-frontend#407).
This will solution will be tried in the new upload target API in the fragalysis backend

If the solution works, then it can also be incorporated here in the loader - or if the new loader API is really good, maybe we won't need to!

@duncanpeacock
Copy link

A fix for this problem in the new data loader is described in the fragalysis backend issue: duncanpeacock/fragalysis-backend#21
The fix in the code for the fragalysis-backend needs to be also made in the loader code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants