Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature Algorithms are hard coded in OAuth2Util.java #788

Open
vihanga-liyanage opened this issue Feb 7, 2018 · 0 comments
Open

Signature Algorithms are hard coded in OAuth2Util.java #788

vihanga-liyanage opened this issue Feb 7, 2018 · 0 comments

Comments

@vihanga-liyanage
Copy link
Contributor

Description:

public static JWSAlgorithm mapSignatureAlgorithmForJWSAlgorithm(String signatureAlgorithm) throws IdentityOAuth2Exception {

Signature algorithms used to sign JWT id tokens are hard coded in this method with an if-else clause. Somewhere down the line when we have to support a new algorithm, we'll have to add a patch to fix this. Instead, we can use the com.nimbusds.jose.JWSAlgorithm#parse method to parse algorithms.

Suggested Labels:
Type/Improvement

Suggested Assignees:
N/A

Affected Product Version:
All

OS, DB, other environment details and versions:
N/A

Steps to reproduce:
N/A

Related Issues:
N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant