Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the /build to a build step instead of versioning it in the repo #3309

Open
jasonbahl opened this issue Feb 12, 2025 · 1 comment
Open
Labels
lang: javascript Pull requests that update JavaScript code scope: build scripts Automating task runners and compilation processes type: chore Maintenance tasks, refactoring, and other non-functional changes

Comments

@jasonbahl
Copy link
Collaborator

What problem does this address?

Currently we are versioning the build output for the GraphiQL IDE and other JS assets (the extensions page, etc)

There's no reason to version these assets in the repo.

What is your proposed solution?

We should move this to a build step when the plugin is being built for deploying to WordPress.org, etc.

What alternatives have you considered?

Leaving it as-is.

Additional Context

I'm not 💯 sure how this would impact folks that install via composer?

@jasonbahl jasonbahl added scope: build scripts Automating task runners and compilation processes lang: javascript Pull requests that update JavaScript code type: chore Maintenance tasks, refactoring, and other non-functional changes labels Feb 12, 2025
@justlevine
Copy link
Collaborator

Additional Context:

  • We're already building in our release CI, so not much needs to change there.
  • Only 'disruptive' change is users who are still checking out GH or the source tree.
    • Good opportunity to refactor script loading and improve the error messages when they're not built.
    • we could add a post-install-cwd to Composer that's npm ci && npm run build, so long as it doesn't leak into wpackagist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang: javascript Pull requests that update JavaScript code scope: build scripts Automating task runners and compilation processes type: chore Maintenance tasks, refactoring, and other non-functional changes
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants