Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Needs tidying to WPCS #20

Closed
phlbnks opened this issue Jun 21, 2017 · 2 comments
Closed

Needs tidying to WPCS #20

phlbnks opened this issue Jun 21, 2017 · 2 comments
Labels
command:media
Milestone
1.0.4

Comments

@phlbnks
Copy link

phlbnks commented Jun 21, 2017 •
edited
Loading

Initial tidying: #19
Outstanding: function args.
@danielbachhuber
Copy link
Member

Outstanding: function args.

I don't think this is something we can fix, actually. Instead, we should eventually add a phpcs.xml that excludes the function args sniff.

Related wp-cli/scaffold-package-command#70

@danielbachhuber danielbachhuber added this to the 1.0.4 milestone Jun 21, 2017
@danielbachhuber
Copy link
Member

I think where it's at is good enough for now. We can pick this up later when wp-cli/scaffold-package-command#70 and wp-cli/wp-cli#3924 land.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
command:media
Projects
None yet
Milestone
1.0.4
Development

No branches or pull requests
2 participants
@danielbachhuber @phlbnks