diff --git a/fastlane/lanes/localization.rb b/fastlane/lanes/localization.rb index 461407800c8c..7a1507239ca7 100644 --- a/fastlane/lanes/localization.rb +++ b/fastlane/lanes/localization.rb @@ -170,11 +170,10 @@ # Defaults to current `versionName`. Only required if skip_release_notes is false # @param [Boolean] skip_release_notes Whether to skip downloading release notes. Default false # @param [Boolean] skip_commit If true, will skip the `git add`, `git commit` and `git push` operations. Default to false. - # @param [Boolean] skip_git_push If true, will skip the `git push` at the end. Default to false. Inferred to `true` if `skip_commit` is `true`. # # @return [void] # - lane :download_metadata_strings do |app: nil, version: current_release_version, skip_release_notes: false, skip_commit: false, skip_git_push: false| + lane :download_metadata_strings do |app: nil, version: current_release_version, skip_release_notes: false, skip_commit: false| version = nil if skip_release_notes # If no `app:` is specified, call this for both WordPress and Jetpack @@ -246,7 +245,6 @@ message += " for #{version}" unless version.nil? git_commit(path: metadata_download_path, message: message, allow_nothing_to_commit: true) end - push_to_git_remote unless skip_commit || skip_git_push end ######################################################################## diff --git a/fastlane/lanes/release.rb b/fastlane/lanes/release.rb index c057787e88ee..7139df17601b 100644 --- a/fastlane/lanes/release.rb +++ b/fastlane/lanes/release.rb @@ -173,6 +173,7 @@ update_frozen_strings_for_translation download_translations + download_metadata_strings(version: current_release_version) # Bump the release version and build code UI.message 'Bumping beta version and build code...' diff --git a/fastlane/lanes/screenshots.rb b/fastlane/lanes/screenshots.rb index 65b59b86c5f7..ab0054b0641e 100644 --- a/fastlane/lanes/screenshots.rb +++ b/fastlane/lanes/screenshots.rb @@ -141,7 +141,7 @@ end app = get_app_name_option!(options) - download_metadata_strings(app: app, skip_release_notes: true, skip_git_push: true) unless options.fetch(:skip_download_strings, false) + download_metadata_strings(app: app, skip_release_notes: true) unless options.fetch(:skip_download_strings, false) # Define intermediate folders raw_screenshots_dir = screenshots_dir(app: app, subfolder: 'raw')