Support SPM installation #1379
Closed
Support SPM installation #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allenhumphreys
commented
Dec 5, 2023
| @@ -967,8 +967,7 @@ | |||
| F1DC21B22199D58B007C189E /* ElementToAttributedString */, | |||
| F1E75630215B0C9E004BC254 /* StringAttributesToAttributes */, | |||
| ); | |||
| name = Converters; | |||
| path = "New Group"; | |||
| path = Converters; | |||
There was a problem hiding this comment.
I noticed that this group was not properly renamed on disk and renamed it so it shows up correctly in SPM.
allenhumphreys
commented
Dec 5, 2023
There was a problem hiding this comment.
This file is not part of the Xcode project, but SPM was picking it up and failing to compile.
allenhumphreys
commented
Dec 5, 2023
There was a problem hiding this comment.
This file is not part of the Xcode project, but SPM was picking it up and failing to compile.
|
I just want to say thanks for the awesome library. I know I didn't ask about adding this support before opening the PR, it's ok if this doesn't align with your goal, though. I had trouble finding your project when looking to solve what this solves, and I'd love to get it listed in the swift package index if this goes through. |
allenhumphreys
force-pushed
the
ah/spm
branch
from
aaeb244 to
1719ce9
Compare
|
good job @allenhumphreys |
|
Thanks for the work here @allenhumphreys – I'm in the midst of reviewing this, but it may take a few more days. Just wanted to provide an update. |
mokagio
added a commit
to wordpress-mobile/WordPress-iOS
that referenced
this pull request
Jan 17, 2025
|
You'll notice that the checks have failed. I pushed #1403 to trigger CI but unfortunately we let this PR sit here for so long that the Xcode tooling its branch uses is out of date. I'll be working on upgrading the tooling first, then update my test branch, then go from there... Also worth noting that when I try to run the tests from Xcode locally from the workspace, they fail to build because they cannot find 
When I try to open |
|
@mokagio i can probably update this branch next week. Running tests from Xcode did originally work, but it’s been quite some time! |
This was referenced Jan 17, 2025
Merged
|
Thanks @allenhumphreys ! I opened #1406 to bring this up to speed. I'd say we're very close to have this officially released. Thanks again for your great contribution! |
|
@mokagio Thanks a bunch! Between my day job and family life, I probably wasn’t actually gonna get to it 😅. Very happy to see this landing. |
|
@allenhumphreys ahah, I know the feeling. Thanks again for this contribution! |
mokagio
added a commit
that referenced
this pull request
Jan 28, 2025
This is a copy of @allenhumphreys' #1379 but with `develop` already merged into it, including conflicts resolution and a necessary commit to add a file to the project so that the tests (which at the moment run via the Xcode project setup, not SwiftPM) could build in CI. I'd love for @allenhumphreys' work to be acknowledged in the GitHub paper-trail. Given this PR is based off #1379, I would expect #1379 to result as merged once this is merged. Alternatively, we could update the base for this to #1379, merge it into it, then merge #1379 into `develop`.
mokagio
added a commit
to wordpress-mobile/WordPress-iOS
that referenced
this pull request
Feb 5, 2025
github-merge-queue bot
pushed a commit
to wordpress-mobile/WordPress-iOS
that referenced
this pull request
Feb 11, 2025
* Run `pod deintegrate` and remove CocoaPods automation * Add `Makefile` automation to download Gutenberg framework * Remove dead reference to `Pods.framework` in project * Remove dead reference to pods from workspace * Remove SwiftLint-via-CocoaPods from `Rakefile` * Remove unnecessary `$(inherited)` flag from a couple of targets That's for the value `CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER`, but it's useless to set `$(inherited)` for a Yes or No value because removing the value from the target will automatically make Xcode read it from the project, achieving the same result. * Remove CocoaPods instruction from the README * Remove SwiftLint instructions from the `README` * Add a version of Aztec fetched via SwiftPM * Add Gutenberg XCFrameworks via drag-n-drop from local paths * Disable `CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER` Was giving errors in Yoga: > Double-quoted include "YGEnums.h" in framework header, expected angle-bracketed instead * Disable `CLANG_WARN_STRICT_PROTOTYPES` It resulted in a build failure: > React.framework/Headers/RCTAppearance.h:16:60: > A function declaration without a prototype is deprecated in all versions of C * Update search path for Gutenberg React Native bundle in script * Remove some leftover bits of CocoaPods set up for automation * Remove leftover `COCOAPODS` precompiler flag Strange that `pod deintegrate` did not remove it. Maybe it was some custom piece of setup... * Remove a couple of CocoaPods-specific code branches * Temporarily switch to CI toolkit branch compatible with no CocoaPods * Fetch XCFrameworks in CI * Update Gutenberg checkout logic in localization lint for CP-less setup * Update source map upload for CP-less Gutenberg setup * Ensure `Frameworks` folder exist, otherwise tar will fail * Remove "Log Outdated Pods" step from code freeze We don't have pods anymore * Remove Pods from lists in `.gitignore` and RuboCop We don't use Pods anymore * Remove imports of Pods xcconfigs * No longer look in Pods folder to extract localizations * Link Gutenberg XCFramework in Jetpack target too! * Add instruction in README to run `make dependencies` * Use CI toolkit 3.8.0 * Point Aztec to branch in wordpress-mobile org from SPM support PR See wordpress-mobile/AztecEditor-iOS#1379 * Point Aztec to latest SwiftPM-support commit * Point to latest Aztec, 1.20.0 * Reimplement logic to download XCFrameworks from `make` to `rake` * Remove a debug `set +x` * Rewrite `gutenberg_xcframeworks` using Ruby APIs More idiomatic and safer than shelling out. See #23958 (comment) * Also delete `tar.gz` when cleaning up after setting up Gutenberg * Ignore `Pods/` for retro-compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1372 #1370
To test:
You can add
.package(url: "https://github.com/allenhumphreys/AztecEditor-iOS", branch: "ah/spm")to the dependencies in a sample application. If needed I can create a repo with a sample application that consumes the package.CHANGELOG.mdif necessary.