From d7ec90fe062b34b21845c652d9b53f3abd60aed9 Mon Sep 17 00:00:00 2001 From: libienz Date: Thu, 5 Dec 2024 19:57:30 +0900 Subject: [PATCH] =?UTF-8?q?test:=20MemberFixture=20=EC=9D=B4=EB=A6=84=20?= =?UTF-8?q?=EB=B3=80=EA=B2=BD=20DEFAULT=5FMEMBER=20->=20TOUROOT=5FLOCAL=5F?= =?UTF-8?q?USER?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../authentication/helper/LoginTestHelper.java | 2 +- .../member/controller/MemberControllerTest.java | 11 ++++++----- .../java/kr/touroot/member/fixture/MemberFixture.java | 2 +- .../kr/touroot/member/helper/MemberTestHelper.java | 4 ++-- .../kr/touroot/member/service/MemberServiceTest.java | 4 ++-- 5 files changed, 12 insertions(+), 11 deletions(-) diff --git a/backend/src/test/java/kr/touroot/authentication/helper/LoginTestHelper.java b/backend/src/test/java/kr/touroot/authentication/helper/LoginTestHelper.java index 70c87307..b2a93767 100644 --- a/backend/src/test/java/kr/touroot/authentication/helper/LoginTestHelper.java +++ b/backend/src/test/java/kr/touroot/authentication/helper/LoginTestHelper.java @@ -13,7 +13,7 @@ public class LoginTestHelper { private final MemberRepository memberRepository; public Member initMemberTestData() { - Member member = MemberFixture.DEFAULT_MEMBER.getMember(); + Member member = MemberFixture.TOUROOT_LOCAL_USER.getMember(); return memberRepository.save(member); } } diff --git a/backend/src/test/java/kr/touroot/member/controller/MemberControllerTest.java b/backend/src/test/java/kr/touroot/member/controller/MemberControllerTest.java index dd02c008..27139f3a 100644 --- a/backend/src/test/java/kr/touroot/member/controller/MemberControllerTest.java +++ b/backend/src/test/java/kr/touroot/member/controller/MemberControllerTest.java @@ -40,7 +40,7 @@ void setUp() { @DisplayName("회원 가입을 한다.") @Test void createTravelogue() { - MemberRequest request = MemberFixture.DEFAULT_MEMBER.getCreateRequest(); + MemberRequest request = MemberFixture.TOUROOT_LOCAL_USER.getCreateRequest(); RestAssured.given().log().all() .contentType(ContentType.JSON) @@ -54,7 +54,7 @@ void createTravelogue() { @DisplayName("비어있는 이메일로 회원 가입하면 예외가 발생한다.") @Test void createTravelogueWithEmptyEmail() { - MemberRequest request = MemberFixture.DEFAULT_MEMBER.getCreateRequestWithEmail(""); + MemberRequest request = MemberFixture.TOUROOT_LOCAL_USER.getCreateRequestWithEmail(""); RestAssured.given().log().all() .contentType(ContentType.JSON) @@ -69,7 +69,7 @@ void createTravelogueWithEmptyEmail() { @ParameterizedTest @ValueSource(strings = {"", "\t", "\n"}) void createTravelogueWithEmptyPassword(String emptyPassword) { - MemberRequest request = MemberFixture.DEFAULT_MEMBER.getCreateRequestWithPassword(emptyPassword); + MemberRequest request = MemberFixture.TOUROOT_LOCAL_USER.getCreateRequestWithPassword(emptyPassword); RestAssured.given().log().all() .contentType(ContentType.JSON) @@ -84,7 +84,7 @@ void createTravelogueWithEmptyPassword(String emptyPassword) { @ParameterizedTest @ValueSource(strings = {"", "\t", "\n"}) void createTravelogueWithEmptyNickname(String emptyNickname) { - MemberRequest request = MemberFixture.DEFAULT_MEMBER.getCreateRequestWithNickname(emptyNickname); + MemberRequest request = MemberFixture.TOUROOT_LOCAL_USER.getCreateRequestWithNickname(emptyNickname); RestAssured.given().log().all() .contentType(ContentType.JSON) @@ -99,7 +99,8 @@ void createTravelogueWithEmptyNickname(String emptyNickname) { @ParameterizedTest @ValueSource(strings = {"", "\t", "\n"}) void createTravelogueWithEmptyProfileImageUrl(String emptyProfileImageUrl) { - MemberRequest request = MemberFixture.DEFAULT_MEMBER.getCreateRequestWithProfileImageUrl(emptyProfileImageUrl); + MemberRequest request = MemberFixture.TOUROOT_LOCAL_USER.getCreateRequestWithProfileImageUrl( + emptyProfileImageUrl); RestAssured.given().log().all() .contentType(ContentType.JSON) diff --git a/backend/src/test/java/kr/touroot/member/fixture/MemberFixture.java b/backend/src/test/java/kr/touroot/member/fixture/MemberFixture.java index bcf9372b..2f033a9d 100644 --- a/backend/src/test/java/kr/touroot/member/fixture/MemberFixture.java +++ b/backend/src/test/java/kr/touroot/member/fixture/MemberFixture.java @@ -18,7 +18,7 @@ public enum MemberFixture { "리비", LoginType.KAKAO ), - DEFAULT_MEMBER( + TOUROOT_LOCAL_USER( null, "email@gmail.com", "password", diff --git a/backend/src/test/java/kr/touroot/member/helper/MemberTestHelper.java b/backend/src/test/java/kr/touroot/member/helper/MemberTestHelper.java index 137e5af8..4feb7eb5 100644 --- a/backend/src/test/java/kr/touroot/member/helper/MemberTestHelper.java +++ b/backend/src/test/java/kr/touroot/member/helper/MemberTestHelper.java @@ -1,6 +1,6 @@ package kr.touroot.member.helper; -import static kr.touroot.member.fixture.MemberFixture.DEFAULT_MEMBER; +import static kr.touroot.member.fixture.MemberFixture.TOUROOT_LOCAL_USER; import kr.touroot.member.domain.Member; import kr.touroot.member.repository.MemberRepository; @@ -18,7 +18,7 @@ public MemberTestHelper(MemberRepository memberRepository) { } public Member persistMember() { - Member member = DEFAULT_MEMBER.getMember(); + Member member = TOUROOT_LOCAL_USER.getMember(); return memberRepository.save(member); } diff --git a/backend/src/test/java/kr/touroot/member/service/MemberServiceTest.java b/backend/src/test/java/kr/touroot/member/service/MemberServiceTest.java index 5af8c91d..44a85a6b 100644 --- a/backend/src/test/java/kr/touroot/member/service/MemberServiceTest.java +++ b/backend/src/test/java/kr/touroot/member/service/MemberServiceTest.java @@ -74,7 +74,7 @@ void getByIdNotExist() { @DisplayName("정상적인 값을 가진 요청이 주어지면 회원을 생성한다.") @Test void createMember() { - MemberRequest request = MemberFixture.DEFAULT_MEMBER.getCreateRequest(); + MemberRequest request = MemberFixture.TOUROOT_LOCAL_USER.getCreateRequest(); Long id = memberService.createMember(request); @@ -99,7 +99,7 @@ void createMemberWithDuplicatedNickname() { Member persistedMember = testHelper.persistMember(); String nonDuplicatedEmail = "noDuplicate" + persistedMember.getEmail(); String duplicatedNickname = persistedMember.getNickname(); - MemberRequest request = MemberFixture.DEFAULT_MEMBER.getCreateRequestWithEmailAndNickname( + MemberRequest request = MemberFixture.TOUROOT_LOCAL_USER.getCreateRequestWithEmailAndNickname( nonDuplicatedEmail, duplicatedNickname );