From c36585130a1939b89ded8120ccefa54368e3d113 Mon Sep 17 00:00:00 2001 From: reddevilmidzy Date: Thu, 26 Sep 2024 21:08:13 +0900 Subject: [PATCH] =?UTF-8?q?refactor:=20=EB=A7=81=ED=81=AC=20findAll=20?= =?UTF-8?q?=EC=A0=9C=EA=B1=B0?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../repository/ReferenceLinkRepository.java | 5 +++++ .../referencelink/service/ReferenceLinkService.java | 13 +++++-------- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/backend/src/main/java/site/coduo/referencelink/repository/ReferenceLinkRepository.java b/backend/src/main/java/site/coduo/referencelink/repository/ReferenceLinkRepository.java index 666ea5dc..a9bbde02 100644 --- a/backend/src/main/java/site/coduo/referencelink/repository/ReferenceLinkRepository.java +++ b/backend/src/main/java/site/coduo/referencelink/repository/ReferenceLinkRepository.java @@ -1,7 +1,12 @@ package site.coduo.referencelink.repository; +import java.util.List; + import org.springframework.data.jpa.repository.JpaRepository; +import site.coduo.pairroom.repository.PairRoomEntity; + public interface ReferenceLinkRepository extends JpaRepository { + List findByPairRoomEntity(PairRoomEntity pairRoomEntity); } diff --git a/backend/src/main/java/site/coduo/referencelink/service/ReferenceLinkService.java b/backend/src/main/java/site/coduo/referencelink/service/ReferenceLinkService.java index 0705ef15..fd9f54c9 100644 --- a/backend/src/main/java/site/coduo/referencelink/service/ReferenceLinkService.java +++ b/backend/src/main/java/site/coduo/referencelink/service/ReferenceLinkService.java @@ -70,10 +70,9 @@ private ReferenceLinkEntity saveReferenceLink(final ReferenceLinkCreateRequest r public List readAllReferenceLink(final String accessCodeText) { log.info("[Reference Link] 2. readAllReferenceLink 메서드 호출 시작!"); log.info("[Reference Link] 3. referenceLinkRepository.findAll() 호출 시작!"); - final List referenceLinkEntities = referenceLinkRepository.findAll() - .stream() - .filter(link -> link.isSameAccessCode(new AccessCode(accessCodeText))) - .toList(); + final PairRoomEntity pairRoom = pairRoomRepository.fetchByAccessCode(accessCodeText); + + final List referenceLinkEntities = referenceLinkRepository.findByPairRoomEntity(pairRoom); log.info("[Reference Link] 4. referenceLinkRepository.findAll() 반환 데이터 필터링 시작!!"); return referenceLinkEntities.stream() @@ -92,9 +91,8 @@ public List findReferenceLinksByCategory( categoryId); final Category category = new Category(categoryEntity.getCategoryName()); - return referenceLinkRepository.findAll() + return referenceLinkRepository.findByPairRoomEntity(pairRoomEntity) .stream() - .filter(link -> link.isSameAccessCode(accessCode)) .filter(link -> link.isSameCategory(category)) .map(this::makeReferenceLinkResponse) .toList(); @@ -111,9 +109,8 @@ public List findReferenceLinksEntityByCategory( categoryId); final Category category = new Category(categoryEntity.getCategoryName()); - return referenceLinkRepository.findAll() + return referenceLinkRepository.findByPairRoomEntity(pairRoomEntity) .stream() - .filter(link -> link.isSameAccessCode(accessCode)) .filter(link -> link.isSameCategory(category)) .toList(); }