Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/240 N+1 문제가 발생하는 부분을 해결한다. #248

Closed
wants to merge 5 commits into from
Closed

Feat/240 N+1 문제가 발생하는 부분을 해결한다. #248

wants to merge 5 commits into from

Conversation

ParkDooWon
Copy link
Collaborator

resolve : #240

toneyparky
toneyparky approved these changes Nov 5, 2020
View reviewed changes
Copy link
Collaborator

@toneyparky toneyparky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다.

minuyim
minuyim reviewed Nov 5, 2020
View reviewed changes
Copy link
Collaborator

@minuyim minuyim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

간단한 궁금사항 남기겠습니다.

...ocktailpick-core/src/main/java/com/cocktailpick/core/cocktail/domain/CocktailRepository.java Outdated
@Query("select c from Cocktail c left join fetch c.cocktailTags where c.id > :id")
List<Cocktail> findByIdGreaterThanWithCocktailTags(long id);

@Query("select c from Cocktail c left join fetch c.cocktailTags left join fetch c.recipe")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

join fetch를 여러번 할 수 있나요?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EntityGraph로 변경해서 조회했습니다! :)

KueNiYam
KueNiYam approved these changes Nov 5, 2020
View reviewed changes
Copy link
Collaborator

@KueNiYam KueNiYam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@KueNiYam KueNiYam closed this Dec 8, 2020
@KueNiYam KueNiYam reopened this Dec 8, 2020
@toneyparky toneyparky closed this Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minuyim minuyim minuyim left review comments

@toneyparky toneyparky toneyparky approved these changes

@KueNiYam KueNiYam KueNiYam approved these changes

Assignees

@KimGyeong KimGyeong

@KueNiYam KueNiYam

@ParkDooWon ParkDooWon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

N+1 문제가 발생하는 부분을 해결한다.
5 participants
@ParkDooWon @KueNiYam @toneyparky @minuyim @KimGyeong