Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Dynamic health and "Coin" health type #724

Open
Tiburones202 opened this issue Sep 13, 2024 · 2 comments
Open

Bug: Dynamic health and "Coin" health type #724

Tiburones202 opened this issue Sep 13, 2024 · 2 comments

Comments

@Tiburones202
Copy link
Contributor

"{{HealingRed}} Heals {1} heart{2}" in "Red to Coin" in "RedToX" does not seem to replace the word "heart" to "coin"

Examples:
The "Heals 2 hearts" line in PHD does not change the word heart to coin (the icon changes tho)
The "Heals 4 hearts" line in Blood Bag does not change the word heart to coin

Extra:
Items such as Charm of the Vampire or The Gamekid still say "heart" instead of "coin", but I think that's not as important

@magagnato4106
Copy link

That's because they probably only attached the RedToX for the Health-ups. They need to extend it for everything that heals.

@Buurazu
Copy link
Collaborator

Buurazu commented Nov 18, 2024

Yeah, it uses a data table for how many containers a Health Up item gives to know what specific numbers to look for in the description text.
PHD and other non-health-up healing items don't have a number assigned to look for, and then blood bag is an outlier because its health up amount is different than its healing amount. It still finds the {{HealingRed}} icon.
Although, it could be hardcoded to look for Heals 2, Heals 3, Heals 4 separately rather than just Heals {1} (same with gamekid/charm text)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants