Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to "try-with" syntax causes invalid output in ERXCompressionUtilities #843

Closed
fbarthez opened this issue Nov 12, 2017 · 0 comments
Closed

Comments

@fbarthez
Copy link
Contributor

Hi @darkv! I have no idea why this happens, but the syntax change introduced in [51edbd7] causes invalid output for at least ERXCompressionUtilities.gzipByteArray() and ERXCompressionUtilities.deflateByteArray(). Code for a basic test class is attached.

ERXCompressionUtilitiesTest.txt

@darkv darkv closed this as completed in 2e8fa57 Nov 13, 2017
fbarthez pushed a commit to schleiereule/wonder that referenced this issue Nov 13, 2017
elemgee added a commit to elemgee/wonder that referenced this issue Dec 20, 2017
* commit 'aa311c01c496de5dd52e777800f43af0f7d4adf4': (22 commits)
  fix casting
  fix strange compiler error
  Javadoc spelling error
  fix white space and indentation
  update libraries
  Fix NPE by applying the replacement only if a non-blank SQL string was returned.
  don’t forget to finish output streams, fixes wocommunity#843
  Declare a specific version of the hamcrest dependency in the pom.xml (issue wocommunity#841)
  Fix issue when running tests with Ant (issue wocommunity#841)
  Add collectors for NSCollection types
  Avoid Maven build failures because of Javadoc generation errors
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release wonder-7.0
  Add Travis-CI build status badge to GitHub front page
  Configure Travis deployment only if branches master
  Run verify Maven goal when building on Travis
  Include WebObjects lib on wotraskd and JavaMonitor
  Add configuration to run tests again
  Configure Travis-CI to build and deploy artifacts to WOCommunity Maven Repository
  Disable the ERModernMoviesTest module temporarily from the Maven build
  ...
elemgee added a commit to elemgee/wonder that referenced this issue Dec 20, 2017
* develop: (22 commits)
  fix casting
  fix strange compiler error
  Javadoc spelling error
  fix white space and indentation
  update libraries
  Fix NPE by applying the replacement only if a non-blank SQL string was returned.
  don’t forget to finish output streams, fixes wocommunity#843
  Declare a specific version of the hamcrest dependency in the pom.xml (issue wocommunity#841)
  Fix issue when running tests with Ant (issue wocommunity#841)
  Add collectors for NSCollection types
  Avoid Maven build failures because of Javadoc generation errors
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release wonder-7.0
  Add Travis-CI build status badge to GitHub front page
  Configure Travis deployment only if branches master
  Run verify Maven goal when building on Travis
  Include WebObjects lib on wotraskd and JavaMonitor
  Add configuration to run tests again
  Configure Travis-CI to build and deploy artifacts to WOCommunity Maven Repository
  Disable the ERModernMoviesTest module temporarily from the Maven build
  ...
rucotec pushed a commit to rucotec/wonder that referenced this issue May 4, 2019
* 'master' of https://github.com/wocommunity/wonder: (496 commits)
  don’t forget to finish output streams, fixes wocommunity#843
  Declare a specific version of the hamcrest dependency in the pom.xml (issue wocommunity#841)
  Fix issue when running tests with Ant (issue wocommunity#841)
  Add collectors for NSCollection types
  Avoid Maven build failures because of Javadoc generation errors
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release wonder-7.0
  Add Travis-CI build status badge to GitHub front page
  Configure Travis deployment only if branches master
  Run verify Maven goal when building on Travis
  Include WebObjects lib on wotraskd and JavaMonitor
  Add configuration to run tests again
  Configure Travis-CI to build and deploy artifacts to WOCommunity Maven Repository
  Disable the ERModernMoviesTest module temporarily from the Maven build
  Configure parallel builds on Maven
  Update .classpath
  match pom versions for com.sun.mail
  update com.sun.mail to 1.6.0
  Fixes wocommunity#834
  update h2 to 1.4.195
  ...

# Conflicts:
#	Frameworks/D2W/ERModernDefaultSkin/WebServerResources/default_screen_stylesheet.css
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant