Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERXStringUtilities.displayNameForKey returns the string "null" for keys with length 1 #834

Closed
NochEinKamel opened this issue Jun 29, 2017 · 0 comments
Closed

ERXStringUtilities.displayNameForKey returns the string "null" for keys with length 1 #834

NochEinKamel opened this issue Jun 29, 2017 · 0 comments

Comments

@NochEinKamel
Copy link
Contributor

The loop in https://github.com/wocommunity/wonder/blob/master/Frameworks/Core/ERExtensions/Sources/er/extensions/foundation/ERXStringUtilities.java#L435 only runs if the key is at least 2 chars long.

For keys which are only one char long (e.g. "y", "n") the method returns a string "null".
I would either expect the input string as it is (perhaps capitalized) or a real null value.
@darkv darkv closed this as completed in b24673b Jul 13, 2017
darkv added a commit that referenced this issue Jul 13, 2017
@darkv
Fixes #834
402c00e 
add support for key with length of 1 in ERXStringUtilities.displayNameForKey
elemgee added a commit to elemgee/wonder that referenced this issue Oct 3, 2017
@elemgee
Merge commit '26f863603bdc0350dd63dbd37f056cacefce328e' into feature/…
3278d5c 
…merge_upstream

* commit '26f863603bdc0350dd63dbd37f056cacefce328e': (81 commits)
  match pom versions for com.sun.mail
  update com.sun.mail to 1.6.0
  Fixes wocommunity#834
  update h2 to 1.4.195
  fix ant attribute value
  add support for ERXKeys for hasKeyChangedFromCommittedSnapshot…
  fix Javadoc generation
  add support for IE11 and Edge browser detection
  Refactors the property names and adds in documentation to the properties file.
  Adds to build.xml list and replaces ERGoogleSignIn/build.xml with alias.
  Adds an entry to the ant build files.
  Adds the essential components and utility classes to the project.
  Adds the required google sign in jars to the project.
  Creates the ERGoogleSignIn framework.
  Set source file encoding for ant tasks, otherwise utf-8 characters would be interpreted as ascii and fail
  use default styling for Javadocs
  Renamed property from removesForeignKeysFromRowValues to removeForeignKeysFromRowValues
  do not use wildcards in import statements
  use parameterized messages for logging
  use diamond operator
  ...
elemgee added a commit to elemgee/wonder that referenced this issue Oct 3, 2017
@elemgee
Merge branch 'develop'
56a8982 
* develop: (81 commits)
  match pom versions for com.sun.mail
  update com.sun.mail to 1.6.0
  Fixes wocommunity#834
  update h2 to 1.4.195
  fix ant attribute value
  add support for ERXKeys for hasKeyChangedFromCommittedSnapshot…
  fix Javadoc generation
  add support for IE11 and Edge browser detection
  Refactors the property names and adds in documentation to the properties file.
  Adds to build.xml list and replaces ERGoogleSignIn/build.xml with alias.
  Adds an entry to the ant build files.
  Adds the essential components and utility classes to the project.
  Adds the required google sign in jars to the project.
  Creates the ERGoogleSignIn framework.
  Set source file encoding for ant tasks, otherwise utf-8 characters would be interpreted as ascii and fail
  use default styling for Javadocs
  Renamed property from removesForeignKeysFromRowValues to removeForeignKeysFromRowValues
  do not use wildcards in import statements
  use parameterized messages for logging
  use diamond operator
  ...
rucotec pushed a commit to rucotec/wonder that referenced this issue May 4, 2019
Merge branch 'master' of https://github.com/wocommunity/wonder
73066d1 
* 'master' of https://github.com/wocommunity/wonder: (496 commits)
  don’t forget to finish output streams, fixes wocommunity#843
  Declare a specific version of the hamcrest dependency in the pom.xml (issue wocommunity#841)
  Fix issue when running tests with Ant (issue wocommunity#841)
  Add collectors for NSCollection types
  Avoid Maven build failures because of Javadoc generation errors
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release wonder-7.0
  Add Travis-CI build status badge to GitHub front page
  Configure Travis deployment only if branches master
  Run verify Maven goal when building on Travis
  Include WebObjects lib on wotraskd and JavaMonitor
  Add configuration to run tests again
  Configure Travis-CI to build and deploy artifacts to WOCommunity Maven Repository
  Disable the ERModernMoviesTest module temporarily from the Maven build
  Configure parallel builds on Maven
  Update .classpath
  match pom versions for com.sun.mail
  update com.sun.mail to 1.6.0
  Fixes wocommunity#834
  update h2 to 1.4.195
  ...

# Conflicts:
#	Frameworks/D2W/ERModernDefaultSkin/WebServerResources/default_screen_stylesheet.css
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NochEinKamel