Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added koinapy and extend superclass #257

Merged
merged 5 commits into from
Sep 13, 2024

Conversation

picciama
Copy link
Contributor

@picciama picciama commented Aug 19, 2024

PR Checklist

  • This comment contains a description of changes (with reason)
  • Referenced issue is linked
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated
  • waiting for new release of koina-py including the required race-condition fix

Description of changes

  • switched out old Koina class with the one the is now implemented in the new koina-py client
  • added the already implemented fix for the race condition on retries in the new Koina class in koina-py

Technical details

  • import new koina-py client and extend the Koina class to add features required by Oktoberfest.

@picciama picciama self-assigned this Aug 19, 2024
@picciama picciama linked an issue Aug 19, 2024 that may be closed by this pull request
@picciama picciama requested a review from JSchlensok September 12, 2024 15:27
@JSchlensok JSchlensok merged commit b655dd4 into feature/dlomix-integration Sep 13, 2024
15 checks passed
@JSchlensok JSchlensok deleted the chore/switch_to_koinapy branch September 13, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oktoberfest crashes with Error message "could not find any target"
2 participants