Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect and suggest models and layers in a feature pack during features add operation #429

Open
spyrkob opened this issue Aug 3, 2023 · 0 comments
Labels
enhancement Enhancement of existing feature ready Issue can be worked on

Comments

@spyrkob
Copy link
Collaborator

spyrkob commented Aug 3, 2023

When user enters prospero feature add --fpl <FEATURE:PACK> --layers <TAB>, prospero should list layers available in that feature pack. Similarly for --model parameter.

Requirements:

  • detect and list available layers and models in a feature pack user selected using --fpl argument
    • see FeaturesAddActiongetAllLayers to check how to analyze the feature pack
  • add an completionCandidates on the layers and modules fields

Test/reproduce setup:

  • install WildFly server using prospero
    prospero install --fpl wildfly --manifest examples/wildfly-29.0.0.Final-manifest.yaml --dir wildfly
  • create a datasources FP manifest (e.g. for datasources FP) and add it together with repositories as a new channel
    follow https://www.wildfly.org/news/2023/11/27/prospero-add-feature-pack/#creating-feature-pack-channel
  • try to add the Datasources feature pack -
    • start entering prospero fp add --fpl org.wildfly:wildfly-datasources-galleon-pack --layers
    • hit TAB key to see candidates
      • nothing will happen
      • after implementing the completion layers supported by the feature pack will be displayed
@spyrkob spyrkob added the enhancement Enhancement of existing feature label Aug 3, 2023
@spyrkob spyrkob added the ready Issue can be worked on label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing feature ready Issue can be worked on
Projects
None yet
Development

No branches or pull requests

1 participant