-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What does FrozenArray mean in dictionaries? #900
Comments
For an output dictionary it might make sense, but maybe it's best forbidden to align with attributes, indeed. |
In general it would be good to align |
Filed w3c/web-share#165 for Web Share. Also came up in Payment Handler API w3c/payment-handler#372 - I've not followed the ObservableArray discussion, but if we can recommend against people using FrozenArray as per the OP, that would be great (ban it outright, even better so tooling catch these and warn spec Editors). |
I noticed a new case of this in web-platform-tests/wpt#28739 and dug up all the current cases of It looks like in most cases it was just copy-pasted from an interface. While one can make sense of what this means and create the frozen arrays, it does seem kind of pointless. Whenever a dictionary is returned it's a new object, is there really any point in making arrays within frozen? |
cc @yoavweiss since WICG/ua-client-hints#228 is very recent, and any rationale might still be in memory :) Or was it just copypasta as it appears? |
@foolip WICG/ua-client-hints#228 was me, and yes it was just copypasta. I'll get it fixed soon-ish |
Thanks for confirming @amtunlimited! |
I think we should prohibit this, FWIW. |
Let's roll this into #1399. |
Web Share has this dictionary:
I guess it has nothing special as a dictionary member or as an argument. Should this be prevented to clarify things?
The text was updated successfully, but these errors were encountered: