Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageDataSettings should probably be called ImageDataOptions #10248

Closed
adroitwhiz opened this issue Apr 4, 2024 · 1 comment
Closed

ImageDataSettings should probably be called ImageDataOptions #10248

adroitwhiz opened this issue Apr 4, 2024 · 1 comment

Comments

@adroitwhiz
Copy link
Contributor

What is the issue with the HTML Standard?

#6562 added the ImageDataSettings interface as part of color space support for canvases--it's an options dict that's passed into the ImageData constructors and canvas' ImageData factory methods.

This breaks with the naming convention for all other options dictionaries, which are named Options and not Settings (e.g. ImageEncodeOptions, ElementDefinitionOptions, etc.)

I'm not well-versed with the finer details of the spec but I don't believe the interface name is exposed anywhere in the API itself, so renaming ImageDataSettings to ImageDataOptions should be a completely normative change.

@domenic
Copy link
Member

domenic commented Apr 4, 2024

It's fine to use varying suffixes when naming dictionaries since they are not exposed anywhere.

@domenic domenic closed this as completed Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants