Enforce stricter slice operations

[orsinium]

Rule request

Thesis

The list has a set of methods that duplicates operations that you can do with + operator or slices:

# bad
items += [item]
# good
items.append(item)

# bad
items = [item] + items
# good
items.insert(0, item)

# bad
items += other
# good
items.extend(other)

# bad
items = items[::-1]
# good
items.reverse()

# bad
items = sorted(items)
# good
items.sort()

# bad
other = items[:]
# good
other = items.copy()

# bad
items[:] = []
# good
items.clear()

# bad
items = items[:-1]
# good
items.pop()

Reasoning

We have two ways to do something. Let's prefer a more descriptive way.

This issue contains a lot of related cases. Consider splitting it by smaller ones.

[orsinium]

If you agree and it's implementable, I can later do the same issue for sets, that's also fun.

[sobolevn]

Let's implement several rules that are not bound to types:

• items[::-1] should not be used. Use reversed or .reverse()
• items[:] should not be used. Use .copy()
• items = items[:-1] should not be used. Use items.pop()

@orsinium as always - awesome suggestions! Thanks!

[Eric4Jiang]

Hi! I would love to contribute and try to resolve this issue if no one else is on it.

[sobolevn]

Sure, @Eric4Jiang! Thanks a lot! Assigned.

[Eric4Jiang]

@sobolevn

Hi! Just to confirm, would items[::] fall into the same category as items[:] because it can be replaced with .copy()?

[sobolevn]

Sure!

[orsinium]

Hmmm, that gives me an idea for one more rule. I've made #1071. Thank you, @Eric4Jiang!

[bDrwx]

Hi, @sobolevn. I'm gonna try to make this issue. Is it still relevant?

[orsinium]

@bDrwx Thank you! Looks like there is still no implementation for the rule. Go ahead! I've assigned you to the issue 👍🏿