Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency mismatch with play 2.6.3 and 2.6.7 #78

Open
alexflav23 opened this issue Nov 7, 2017 · 3 comments
Open

Dependency mismatch with play 2.6.3 and 2.6.7 #78

alexflav23 opened this issue Nov 7, 2017 · 3 comments

Comments

@alexflav23
Copy link

I have a small problem after upgrading to play 2.6.3 and using webjars 2.6.1, have not changed any of the code outside of the versions.

3) Error injecting constructor, java.lang.NoSuchMethodError: controllers.AssetsBuilder.<init>(Lplay/api/http/HttpErrorHandler;)V
[info]   at controllers.WebJarAssets.<init>(WebJarAssets.scala:19)
[info]   at controllers.WebJarAssets.class(WebJarAssets.scala:19)
[info]   while locating controllers.WebJarAssets

Have you seen this before as it looks like a binary incompatibility at library level?

@alexflav23 alexflav23 changed the title Dependency mismatch with play 2.6.3 Dependency mismatch with play 2.6.3 and 2.6.7 Nov 8, 2017
@jamesward
Copy link
Member

This might be due to some API changes: v2.6.0...v2.6.1

Can you check the updated WebJars Play docs: http://www.webjars.org/documentation#play2

Let me know if that helps.

BTW: Our versioning follows Play versioning to indicate compat with Play. But it doesn't follow semver at the library level. This is a pain - sorry.

@alexflav23
Copy link
Author

alexflav23 commented Nov 8, 2017

@jamesward It is because the WebJarAssets implicitly included in scope somehow was controller.WebjarAssets. I still don't and cannot understand where that came from, because it doesn't seem included in the code. That variant was not passing through the errorHandler and something else to controllers.AssetBuilder, so it ended up being a runtime incompatible class change error basically.

I worked it out in the end, but I really don't know if that controllers.WebJarAssets is somehow a problem on our end or if it could be something affecting other people, I suppose you have better insight there.

Happy to help with more details or anything, I even upgraded webjars-play to use play-2.6.7 and everything worked, so I can only assume it gets corrupted on our end?

@jamesward
Copy link
Member

Very odd. But glad we have info here in case anyone else runs into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants