Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.13 breakage #49868

Closed
emilio opened this issue Jan 2, 2025 · 2 comments
Closed

Python 3.13 breakage #49868

emilio opened this issue Jan 2, 2025 · 2 comments

Comments

@emilio
Copy link
Contributor

emilio commented Jan 2, 2025

Trying to ./wpt serve (or running WPT from a firefox source tree) with python 3.13 fails with:

Traceback (most recent call last):
  File "/home/emilio/src/moz/gecko-3/testing/web-platform/tests/./wpt", line 10, in <module>
    wpt.main()
    ~~~~~~~~^^
  File "/home/emilio/src/moz/gecko-3/testing/web-platform/tests/tools/wpt/wpt.py", line 211, in main
    script, parser = import_command(prog, command, props)
                     ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^
  File "/home/emilio/src/moz/gecko-3/testing/web-platform/tests/tools/wpt/wpt.py", line 102, in import_command
    mod = __import__(mod_name)
  File "/home/emilio/src/moz/gecko-3/testing/web-platform/tests/tools/serve/__init__.py", line 1, in <module>
    from . import serve  # noqa: F401
    ^^^^^^^^^^^^^^^^^^^
  File "/home/emilio/src/moz/gecko-3/testing/web-platform/tests/tools/serve/serve.py", line 27, in <module>
    from wptserve import server as wptserve, handlers
  File "/home/emilio/src/moz/gecko-3/testing/web-platform/tests/tools/wptserve/wptserve/__init__.py", line 1, in <module>
    from .server import WebTestHttpd, WebTestServer, Router  # noqa: F401
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/emilio/src/moz/gecko-3/testing/web-platform/tests/tools/wptserve/wptserve/server.py", line 29, in <module>
    from . import routes as default_routes
  File "/home/emilio/src/moz/gecko-3/testing/web-platform/tests/tools/wptserve/wptserve/routes.py", line 1, in <module>
    from . import handlers
  File "/home/emilio/src/moz/gecko-3/testing/web-platform/tests/tools/wptserve/wptserve/handlers.py", line 13, in <module>
    from .request import Authentication
  File "/home/emilio/src/moz/gecko-3/testing/web-platform/tests/tools/wptserve/wptserve/request.py", line 4, in <module>
    import cgi
ModuleNotFoundError: No module named 'cgi'

It seems the cgi module is gone.

Commenting that import out I get:

Traceback (most recent call last):
  File "/home/emilio/src/moz/gecko-3/testing/web-platform/tests/./wpt", line 10, in <module>
    wpt.main()
    ~~~~~~~~^^
  File "/home/emilio/src/moz/gecko-3/testing/web-platform/tests/tools/wpt/wpt.py", line 233, in main
    rv = script(*args, **kwargs)
  File "/home/emilio/src/moz/gecko-3/testing/web-platform/tests/tools/serve/serve.py", line 1426, in run
    with build_config(logger,
         ~~~~~~~~~~~~^^^^^^^^
                      os.path.join(repo_root, "config.json"),
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                      config_cls=config_cls,
                      ^^^^^^^^^^^^^^^^^^^^^^
                      **kwargs) as config:
                      ^^^^^^^^^
  File "/home/emilio/src/moz/gecko-3/testing/web-platform/tests/tools/serve/serve.py", line 1314, in build_config
    rv = config_cls(logger)
TypeError: 'Virtualenv' object is not callable

Which is a new one and not sure how to quite get through.

cc @jgraham

@emilio
Copy link
Contributor Author

emilio commented Jan 2, 2025

I guess kind of a dupe of #48585

@gsnedders
Copy link
Member

I guess kind of a dupe of #48585

Yup.

@gsnedders gsnedders closed this as not planned Won't fix, can't repro, duplicate, stale Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants