Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reversed players are immediately removed when their current time is at their source end time #587

Open
alancutter opened this issue Apr 23, 2014 · 0 comments
Labels

Comments

@alancutter
Copy link
Contributor

The call to player._hasFutureEffect() in ticker() does not take into account the direction of the player.

    if (!player._hasFutureEffect()) {
      finishedPlayers.push(player);
    }

If the player is reversed and its current time is equal to its source's end time then the check will report that there is no future effect and the player will be removed.

@alancutter alancutter added the bug label Apr 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant