Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "tag" support on structs, members, enums and enum-members #35

Closed
wc-duck opened this issue Nov 26, 2015 · 11 comments
Closed

Add "tag" support on structs, members, enums and enum-members #35

wc-duck opened this issue Nov 26, 2015 · 11 comments

Comments

@wc-duck
Copy link
Owner

wc-duck commented Nov 26, 2015

It should be possible to add "tags" to each of the above mentioned parts of a typelibrary for the user to use as they see fit. ( mostly for editor/tools use ).

A tag should be any string and dl will put no meaning to these. On each of the aboved items a list of these tags should be valid.

Tags use-case examples:
"file" to indicate that a string should be a file
"range(0,100)" to say the range of an int.
"slider" should be edited by a slider in some editor.
Note: This will NOT be implemented by dl, only the tag-support.

@lundmark
Copy link
Collaborator

Oh +1! That would be awesome.

@lundmark
Copy link
Collaborator

After having checked out how the member parsing / implementation is done, I think I could probably fix this feature and create a pull-request if wanted?

@wc-duck
Copy link
Owner Author

wc-duck commented Jan 15, 2018

Maybe... There is one other possible solution to this, but it is more complicated. Just making metadata an array of dl-structs. Then we could embed any metadata without having dl dictate what that metadata is.

@lundmark
Copy link
Collaborator

Hmmm, not sure what you mean with "array of dl-structs" in this context?

@wc-duck
Copy link
Owner Author

wc-duck commented Jan 15, 2018

You define your metadata as dl-types and then the metadata of a type as

"metadata" : [ { "range" : { "min" : 1, "max" : 5 } ]

@wc-duck
Copy link
Owner Author

wc-duck commented Jan 15, 2018

On types or on members that is!

@lundmark
Copy link
Collaborator

Ooooooooooooooooohhhhhhhhhhhhhhhh... That's really nice!

@lundmark
Copy link
Collaborator

To be honest I think that this is maybe solved by the comment-functionality, or what do you think?

@wc-duck
Copy link
Owner Author

wc-duck commented Aug 21, 2018

I still think metadata is a better solution, but maybe that is better as a new issue?

@lundmark
Copy link
Collaborator

Hmmm yeah probably a new issue. It's a completely different system and even more awesome to be honest.

@wc-duck
Copy link
Owner Author

wc-duck commented Aug 23, 2018

Replaced by #97

@wc-duck wc-duck closed this as completed Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants