Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glitchy selection box in dimension mode #5

Open
CheerfulPianissimo opened this issue Mar 29, 2024 · 9 comments
Open

Glitchy selection box in dimension mode #5

CheerfulPianissimo opened this issue Mar 29, 2024 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@CheerfulPianissimo
Copy link

Here's a recording. Compositor is sway and it's running on an AMD radeon iGPU.

waysip_bug.webm
@Shinyzenith Shinyzenith added the bug Something isn't working label Mar 29, 2024
@Shinyzenith Shinyzenith self-assigned this Mar 29, 2024
@Shinyzenith
Copy link
Member

CC: @Decodetalkers

@shivkr6
Copy link

shivkr6 commented Mar 29, 2024

For me it's flickering, Compositor is river and it's running on an AMD Radeon iGPU.

@Decodetalkers
Copy link
Collaborator

I cannot find out what's wrong, I do not know much about Cairo...so I need help

@CheerfulPianissimo CheerfulPianissimo changed the title Glitchy selection box in description mode Glitchy selection box in dimension mode Mar 29, 2024
@Shinyzenith
Copy link
Member

Can we get some WAYLAND_DEBUG=1 logs?

@Shinyzenith
Copy link
Member

Sway 1.9, GLES2 renderer, things seem to be working just fine on my intel card. Awaiting further logs/steps to reproduce.

@CheerfulPianissimo
Copy link
Author

Here's some logs
logs.txt

@CheerfulPianissimo
Copy link
Author

Can no longer replicate this. Seems like something in the recent commits solved this?

@Decodetalkers
Copy link
Collaborator

Can no longer replicate this. Seems like something in the recent commits solved this?

it sometimes happens. when I have a second screen it maybe will flash I do not know what is wrong

@CheerfulPianissimo
Copy link
Author

CheerfulPianissimo commented Apr 10, 2024

Alright, it seems to be back or maybe it never left in the first place.

Looking at the flamegraph and playing around a bit it seems that the problem lies in cairo::paint and cairo::fill being very slow for some reason. I commented out the text rendering and changed the paint command to a fill of a smaller area and the situation is a bit improved. There's some artifacting but none of the flicker. It's still doesn't feel smooth though.

waysip_patch.webm

The part I'm confused by is the reason for the flickering in the first place: it happens whenever fill or paint takes too long but shouldn't the double buffering via surface.commit prevent incomplete frames from being rendered?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

4 participants