Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

map is sometimes displaced, depending on load times #493

Open
robstoll opened this issue Dec 17, 2021 · 1 comment
Open

map is sometimes displaced, depending on load times #493

robstoll opened this issue Dec 17, 2021 · 1 comment
Assignees
@robstoll
Labels
Bug https://github.com/dotnet/roslyn/wiki/Labels-used-for-issues#bugs

Comments

@robstoll
Copy link
Contributor

Describe the bug
Depending on loading times of the map tiles it happens that the this.map.resize() occurs too early and the map is not resized correctly

To Reproduce
load the map enough times, at some point you will see:

image

instead of

image

Which has the effect, that the desired bounding box of the city zurich is not in the middle
@robstoll robstoll added the Bug https://github.com/dotnet/roslyn/wiki/Labels-used-for-issues#bugs label Dec 17, 2021
@robstoll robstoll self-assigned this Dec 17, 2021
@robstoll robstoll added this to Board Dec 17, 2021
@robstoll robstoll moved this to In Progress in Board Dec 17, 2021
@robstoll
Copy link
Contributor Author

Found the issue, on first map rendering, the resize has to happen before the first fitBounds

robstoll added a commit to tegonal/proximap that referenced this issue Dec 17, 2021
@robstoll
water-fountains#491 loc / water-fountains#493 map.resize / water-foun…
18f2762 
…tains#489 switch between cities

moreover:
- water-fountains#490 do not handle programmatic route changes
- fix some null vs. undefined issues
- update mapboxgl to latest version

not included yet in this commit:
- loading fountains outside of a city
robstoll added a commit to tegonal/proximap that referenced this issue Dec 17, 2021
@robstoll
water-fountains#491 loc / water-fountains#493 map.resize / water-foun…
039d94c 
…tains#489 switch between cities

moreover:
- water-fountains#490 do not handle programmatic route changes
- fix some null vs. undefined issues
- update mapboxgl to latest version

not included yet in this commit:
- loading fountains outside of a city
robstoll added a commit to tegonal/proximap that referenced this issue Dec 17, 2021
@robstoll
water-fountains#491 loc / water-fountains#493 map.resize / water-foun…
1724149 
…tains#489 switch between cities

moreover:
- water-fountains#490 do not handle programmatic route changes
- fix some null vs. undefined issues
- update mapboxgl to latest version

not included yet in this commit:
- loading fountains outside of a city
robstoll added a commit to tegonal/proximap that referenced this issue Dec 17, 2021
@robstoll
water-fountains#491 loc / water-fountains#493 map.resize / water-foun…
64fe564 
…tains#489 switch between cities

moreover:
- water-fountains#490 do not handle programmatic route changes
- fix some null vs. undefined issues
- update mapboxgl to latest version

not included yet in this commit:
- loading fountains outside of a city
robstoll added a commit that referenced this issue Dec 17, 2021
@robstoll
Merge pull request #494 from tegonal/shared-location
b3315db 
#491 loc / #493 map.resize / #489 switch between cities
@robstoll robstoll moved this from In Progress to Verify in Board Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robstoll robstoll

Labels
Bug https://github.com/dotnet/roslyn/wiki/Labels-used-for-issues#bugs
Projects
Board
Status: Verify
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robstoll