Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix location keys derived from json, use datablue types #391

Merged

Conversation

robstoll
Copy link
Contributor

@robstoll robstoll commented Jul 9, 2021

Currently copy & paste, we should introduce an own lib for those types
instead or mabye even better use a monorepo as an own lib looks like
overkill in this small project

@robstoll robstoll linked an issue Jul 9, 2021 that may be closed by this pull request
@robstoll robstoll force-pushed the fix/#383-selector.default branch from 6c93759 to 83dc688 Compare July 9, 2021 16:02
Currently copy & paste, we should introduce an own lib for those types
instead or mabye even better use a monorepo as an own lib looks like
overkill in this small project
@robstoll robstoll force-pushed the fix/#383-selector.default branch from 83dc688 to 188ef7a Compare July 9, 2021 16:05
@robstoll robstoll merged commit ce24bb1 into water-fountains:develop Jul 9, 2021
@robstoll robstoll deleted the fix/#383-selector.default branch July 16, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

selector.default should not be visible or have a proper text
1 participant