Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icon doesn't turn black despite osm #251

Open
ralfhauser opened this issue Jun 15, 2019 · 6 comments
Open

icon doesn't turn black despite osm #251

ralfhauser opened this issue Jun 15, 2019 · 6 comments
Labels
4 - In Review ready to submit a PR for review.

Comments

@ralfhauser
Copy link
Member

as per #206 (comment)

https://beta.water-fountains.org/ch-zh?l=de&i=Q55170911

image

even though
image

@mmmatthew
Copy link
Member

the issue here is that there is conflicting information: amenity=drinking_water and drinking_water=no.

Data extraction rules should be made more transparent and displayed in the property details view.

@ralfhauser
Copy link
Member Author

ok, changed it to "amenity=fountain" like
https://beta.water-fountains.org/ch-zh?l=en&i=Q27229673
(Alfred Escher Brunnen)

mmmatthew added a commit to water-fountains/datablue that referenced this issue Jun 17, 2019
@mmmatthew
Copy link
Member

ok, changed it to "amenity=fountain" like
https://beta.water-fountains.org/ch-zh?l=en&i=Q27229673
(Alfred Escher Brunnen)

It doesn't really look like a fountain to me. The following tag is more appropriate:
https://wiki.openstreetmap.org/wiki/Talk:Tag:man_made%3Dwater_tap

@mmmatthew
Copy link
Member

I have fixed the processing in water-fountains/datablue@6887c90, so that if drinking_water=no, then that trumps any inferred properties.

@mmmatthew mmmatthew added the 4 - In Review ready to submit a PR for review. label Jun 28, 2019
@FlipHaesli
Copy link

This still doesn't work for
https://www.openstreetmap.org/way/495224204 or https://www.wikidata.org/wiki/Q65095943 respectively

@mmmatthew
Copy link
Member

@FlipHaesli what behavior were you expecting for the pond you refer to? I see the following, which seems reasonable:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - In Review ready to submit a PR for review.
Projects
None yet
Development

No branches or pull requests

3 participants