-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
image not found despite refresh #212
Comments
Currently, only fountains with coordinates, are collected from wikidata.
I would also note that from the image, it appears to be a pond and not a
well. Many fountains are falsely labeled as wells or water wells in
wikidata.
|
|
2. Yes there are many: all the red and green dots here
https://tools.wmflabs.org/wikishootme/index.html#lat=47.366228237972294&lng=8.532457722049003&zoom=14&sparql_filter=%3Fq%20wdt%3AP31%2Fwdt%3AP279*%20wd%3AQ43483
If you check the definition of "well" in wikidata, you will see that it
does not apply to most of them and should actually be removed.
|
|
I understand that you are suggesting 3 a) as a replacement for 1. However, 1 is more straightforward to implement. |
pls start with 1) and keep the issue open until 3) is done |
Hi Matthew |
One more time.... |
I can try to solve it this morning.
|
Terrific, thank you
Von: mmmatthew <[email protected]>
Gesendet: Monday, 27 May 2019 08:22
An: water-fountains/proximap <[email protected]>
Cc: katjahenke <[email protected]>; Comment <[email protected]>
Betreff: Re: [water-fountains/proximap] image not found despite refresh (#212)
I can try to solve it this morning.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#212?email_source=notifications&email_token=AL2RG7FEOIDBEYSTT7DUTZTPXN4WXA5CNFSM4HMJBAO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWI4MKY#issuecomment-496092715> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AL2RG7DFA5JF6ONS5FMNXXTPXN4WXANCNFSM4HMJBAOQ> .
|
@katjahenke can you check that the issue is fixed? |
Yes, it's done! Many thanks |
Hi Matthew |
Hi Katja,
I took a quick look at some of your Wikidata entities, and suspect that
there is a problem with the data entry in Wikidata.
In order for a fountain to appear, the Wikidata item should have the
following information provided:
- the statement `instance of``fountain` and/or `drinking fountain`
- geographical coordinates
In the special case where the Wikidata entity is referenced in the
OpenStreetMap version of the fountain (see for example
https://www.openstreetmap.org/node/1747364087), then the coordinates are
not needed in Wikidata.
Hope that helps
|
Hi Matthew,
Thank you for the feedback. All has been well noted.
We will make sure to adjust all entries accordingly.
Kind regards,
Katja
|
After talking on the phone, we figured out that one issue is that Wikidata expects coordinates in the latitude - longitude order (like 47.3124, 8.7430), but they were being entered in the longitude-latitude format (like 8.7430, 47.32421). |
https://www.wikidata.org/wiki/Q64213962 looks a lot better, but |
Q64213962 is just a pond, so it is not indexed by datablue. According to the suggestion in #242 (comment), man-made ponds might also be included by datablue even though they are not fountains. https://www.wikidata.org/wiki/Q63715939 does appear in water-fountains because it is falsely labelled as a well. |
But once #242 (comment) is implemented, the problem will go away from Q63715939 ? I also changed https://www.wikidata.org/wiki/Q64213962 to man-made-pond , so also that will then work ? |
https://www.wikidata.org/wiki/Q64513188 has duplicate https://www.wikidata.org/wiki/Q64213962 tried to do a merge |
https://beta.water-fountains.org/zurich?lang=de&queryType=byId&database=wikidata&idval=Q63715939
https://commons.wikimedia.org/wiki/File:Brunnen_27.jpg exists and is mentioned in https://www.wikidata.org/wiki/Q63715939 but doesn't show.
Admitted, the wikidata doesn't have the coordinates, but if OSM has the wikidata ID (#211) is that really still needed ?
The text was updated successfully, but these errors were encountered: