Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image not found despite refresh #212

Closed
ralfhauser opened this issue May 11, 2019 · 20 comments
Closed

image not found despite refresh #212

ralfhauser opened this issue May 11, 2019 · 20 comments
Labels
Milestone

Comments

@ralfhauser
Copy link
Member

https://beta.water-fountains.org/zurich?lang=de&queryType=byId&database=wikidata&idval=Q63715939

https://commons.wikimedia.org/wiki/File:Brunnen_27.jpg exists and is mentioned in https://www.wikidata.org/wiki/Q63715939 but doesn't show.

Admitted, the wikidata doesn't have the coordinates, but if OSM has the wikidata ID (#211) is that really still needed ?

@mmmatthew
Copy link
Member

mmmatthew commented May 12, 2019 via email

@ralfhauser
Copy link
Member Author

  1. let's also collect wikidata fountains without coordinates, provided they are referenced by OSM where that has a coordinate

  2. I added "instance of pond" - you really think there are many ?

@mmmatthew
Copy link
Member

mmmatthew commented May 13, 2019 via email

@ralfhauser
Copy link
Member Author

  1. suggest to be even more relaxed: if
    a) a fountain has an osm entry linking to a wikidata Q-ID and no pic otherwsie, but wikidata entry has an image, show it
    b) in the merging algorithm search also for "tap" Q656656 (e.g. https://www.wikidata.org/wiki/Q64015724)

@ralfhauser ralfhauser added this to the Out of Beta milestone May 25, 2019
@mmmatthew
Copy link
Member

I understand that you are suggesting 3 a) as a replacement for 1. However, 1 is more straightforward to implement.

@ralfhauser
Copy link
Member Author

pls start with 1) and keep the issue open until 3) is done

@katjahenke
Copy link

Hi Matthew
Any news on #212?
It would be terrific if it could be solved by Thursday morning, before we go on our Fountain-Tour. Any Chance? Happy Monday, Katja

@katjahenke
Copy link

One more time....
#212

@mmmatthew
Copy link
Member

mmmatthew commented May 27, 2019 via email

@katjahenke
Copy link

katjahenke commented May 27, 2019 via email

mmmatthew added a commit to water-fountains/datablue that referenced this issue May 27, 2019
@mmmatthew mmmatthew added 4 - In Review ready to submit a PR for review. backend Feature Request For new features labels May 27, 2019
@mmmatthew
Copy link
Member

@katjahenke can you check that the issue is fixed?

@katjahenke
Copy link

Yes, it's done! Many thanks
Katja

@katjahenke
Copy link

Hi Matthew
Julia and I keep running into the same issue....
We uplad a photograph but when we atempt to refresh the fountain info/pic, it does not change the picture.
Q64213962
Q64214288
Q55170723
Q55166214
Q147276
Q64220833
Q64220847
Q64220859
Please let us know what we are doing wrong.
Thank you

@mmmatthew
Copy link
Member

mmmatthew commented Jun 4, 2019 via email

@katjahenke
Copy link

katjahenke commented Jun 4, 2019 via email

@mmmatthew
Copy link
Member

After talking on the phone, we figured out that one issue is that Wikidata expects coordinates in the latitude - longitude order (like 47.3124, 8.7430), but they were being entered in the longitude-latitude format (like 8.7430, 47.32421).

@ralfhauser
Copy link
Member Author

https://www.wikidata.org/wiki/Q64213962 looks a lot better, but
https://beta.water-fountains.org/ch-zh?l=de&i=Q64213962 still dies in an awkward, non-telling way (#206 (comment)) - what is still wrong?

@mmmatthew
Copy link
Member

Q64213962 is just a pond, so it is not indexed by datablue. According to the suggestion in #242 (comment), man-made ponds might also be included by datablue even though they are not fountains.

https://www.wikidata.org/wiki/Q63715939 does appear in water-fountains because it is falsely labelled as a well.

@ralfhauser
Copy link
Member Author

https://www.wikidata.org/wiki/Q63715939 does appear in water-fountains because it is falsely labelled as a well.

But once #242 (comment) is implemented, the problem will go away from Q63715939 ?

I also changed https://www.wikidata.org/wiki/Q64213962 to man-made-pond , so also that will then work ?

@ralfhauser
Copy link
Member Author

@ralfhauser ralfhauser removed the 4 - In Review ready to submit a PR for review. label Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants