Skip to content
This repository has been archived by the owner on Jun 25, 2024. It is now read-only.

Should ACL option be excluded if cdnPath is specified? #357

Open
ffxsam opened this issue Dec 13, 2021 · 0 comments
Open

Should ACL option be excluded if cdnPath is specified? #357

ffxsam opened this issue Dec 13, 2021 · 0 comments

Comments

@ffxsam
Copy link
Contributor

ffxsam commented Dec 13, 2021

S3 buckets behind a CDN don't need public read access at all. So when I try to deploy to my S3 bucket, I get "access denied" because the putObject call is doing ACL: 'public-read'.

There's also another bug where if you specify a cdnPath like this:

cdnPath: https://cdn.site.org/subfolder

the files get put at the root level in the S3 bucket, e.g. v1.0/file1.js rather than subfolder/v1.0/file1.js.

I'm happy to open PRs for these.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant