From 7cbbdaad8b2b11d4e0753de4afdfc048307d2a09 Mon Sep 17 00:00:00 2001
From: SuperBatata <khaledbattiche@gmail.com>
Date: Tue, 28 Jan 2025 17:15:02 +0100
Subject: [PATCH] fix : clean up code and add more checks

---
 .../walt/policies/policies/DynamicPolicy.kt   | 22 +++++--------------
 1 file changed, 5 insertions(+), 17 deletions(-)

diff --git a/waltid-libraries/credentials/waltid-verification-policies/src/commonMain/kotlin/id/walt/policies/policies/DynamicPolicy.kt b/waltid-libraries/credentials/waltid-verification-policies/src/commonMain/kotlin/id/walt/policies/policies/DynamicPolicy.kt
index e96a4f767..bf9eadc1b 100644
--- a/waltid-libraries/credentials/waltid-verification-policies/src/commonMain/kotlin/id/walt/policies/policies/DynamicPolicy.kt
+++ b/waltid-libraries/credentials/waltid-verification-policies/src/commonMain/kotlin/id/walt/policies/policies/DynamicPolicy.kt
@@ -81,11 +81,6 @@ class DynamicPolicy : CredentialDataValidatorPolicy() {
         val regoCode = rules["rego"]
             ?: return Result.failure(Exception("The 'rego' code is required in the 'rules' field."))
 
-
-        println("regoCode: $regoCode")
-        println("argument: $argument")
-
-
         val cleanedRegoCode = """
             ${
             cleanCode(regoCode.jsonPrimitive.content)
@@ -98,35 +93,28 @@ class DynamicPolicy : CredentialDataValidatorPolicy() {
             setBody(cleanedRegoCode)
         }
 
-        println("upload: ${upload.bodyAsText()}")
+        check(upload.status.isSuccess()) {
+            "Failed to upload the policy to OPA. Check the policy code (rego) and try again."
+        }
+
         val input = mapOf(
             "parameter" to argument,
             "credentialData" to data.toMap()
         ).toJsonObject()
 
 
-        println("input: $input")
-
         // verify the policy
         val response: HttpResponse = http.post("$policyServer/v1/data/$policyQuery/$policyName") {
             contentType(ContentType.Application.Json)
             setBody(mapOf("input" to input))
         }
 
-        println("response: ${response.bodyAsText()}")
-
 
 
         val result = response.body<JsonObject>()["result"]?.jsonObject
-            ?: throw IllegalArgumentException("The response does not contain a 'result' field.")
-
-        println("result: $result")
+            ?: throw IllegalArgumentException("Something went wrong while verifying the policy.")
 
-
-        // check if the policy is passed
         val allow = result["allow"]
-        println("allow: $allow")
-
 
         // delete the policy from OPA
         http.delete("$policyServer/v1/policies/$policyName")