Add validations for Credential Issuer Identifier and Cryptographic Bi…

…nding Methods
walt-id · Feb 17, 2025 · 7ae152e · 7ae152e
1 parent 951a778
commit 7ae152e
Showing 1 changed file with 38 additions and 1 deletion.
diff --git a/...d-libraries/protocols/waltid-openid4vc/src/commonMain/kotlin/id/walt/oid4vc/OpenID4VCI.kt b/...d-libraries/protocols/waltid-openid4vc/src/commonMain/kotlin/id/walt/oid4vc/OpenID4VCI.kt
@@ -325,7 +325,16 @@ object OpenID4VCI {
         return payload
     }
 
-    fun createDefaultProviderMetadata(baseUrl: String, credentialSupported: Map<String, CredentialSupported>? = null, version: OpenID4VCIVersion, customParameters: Map<String, JsonElement>? = emptyMap()) : OpenIDProviderMetadata {
+    fun createDefaultProviderMetadata(
+        baseUrl: String,
+        credentialSupported: Map<String, CredentialSupported>? = null,
+        version: OpenID4VCIVersion,
+        customParameters: Map<String, JsonElement>? = emptyMap()
+    ): OpenIDProviderMetadata {
+
+        validateCredentialIssuerUrl(baseUrl)
+
+        credentialSupported?.let { validateCryptographicBindingMethods(it) }
 
         return when (version) {
             OpenID4VCIVersion.DRAFT13 -> OpenIDProviderMetadata.Draft13(
@@ -387,6 +396,34 @@ object OpenID4VCI {
         }
     }
 
+
+    fun validateCredentialIssuerUrl(url: String) {
+        try {
+            val parsedUrl = Url(url)
+
+            require(parsedUrl.protocol.name == "https" || parsedUrl.protocol.name == "https") { "URL must use HTTPS or HTTP scheme" }
+            require(parsedUrl.host.isNotEmpty()) { "URL must have a valid host" }
+            require(parsedUrl.parameters.isEmpty() && !url.contains("#")) { "URL must not contain query or fragment" }
+
+        } catch (e: IllegalArgumentException) {
+            throw IllegalArgumentException("Invalid Credential Issuer URL: ${e.message}")
+        }
+    }
+
+    fun validateCryptographicBindingMethods(credentialSupported: Map<String, CredentialSupported>) {
+        credentialSupported.forEach {
+
+            val validFormats = setOf("jwk", "cose_key")
+            val didPattern = Regex("^did:[a-z0-9]+$")
+
+            it.value.cryptographicBindingMethodsSupported?.forEach { method ->
+                require(method in validFormats || didPattern.matches(method)) {
+                    "Invalid cryptographic binding method: $method. Expected 'jwk', 'cose_key', or 'did:<method-name>'"
+                }
+            }
+        }
+    }
+
     fun getNonceFromProof(proofOfPossession: ProofOfPossession) = when (proofOfPossession.proofType) {
         ProofType.jwt -> JwtUtils.parseJWTPayload(proofOfPossession.jwt!!)[JWTClaims.Payload.nonce]?.jsonPrimitive?.content
         ProofType.cwt -> Cbor.decodeFromByteArray<COSESign1>(proofOfPossession.cwt!!.base64UrlDecode()).decodePayload()?.let { payload ->