Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: skip repository refresh when repo is disabled #872

Merged
merged 4 commits into from
Feb 27, 2024
Merged

server: skip repository refresh when repo is disabled #872

merged 4 commits into from
Feb 27, 2024

Conversation

benbroadaway
Copy link
Collaborator

@benbroadaway benbroadaway commented Feb 9, 2024 •
edited
Loading

Currently, a repo cannot be disabled if there's something wrong with the config (auth, branch/tag, path etc).

@benbroadaway benbroadaway requested review from ibodrov and a team February 9, 2024 13:54
dankle
dankle previously approved these changes Feb 9, 2024
View reviewed changes
@benbroadaway benbroadaway added the wip Work in progress, do not merge label Feb 9, 2024
@benbroadaway benbroadaway marked this pull request as draft February 9, 2024 16:44
@benbroadaway benbroadaway marked this pull request as ready for review February 12, 2024 16:54
@benbroadaway benbroadaway added wip Work in progress, do not merge and removed wip Work in progress, do not merge labels Feb 12, 2024
@benbroadaway
Copy link
Collaborator Author

need to double-check cron triggers are cleared out appropriately...

@benbroadaway benbroadaway removed the wip Work in progress, do not merge label Feb 13, 2024
@benbroadaway
Copy link
Collaborator Author

need to double-check cron triggers are cleared out appropriately...

👍👍 trigger_schedule is cleaned up with cascading deletes from the triggers table

@ibodrov ibodrov merged commit 4e77aa9 into master Feb 27, 2024
2 checks passed
@ibodrov ibodrov deleted the disable-disabled-repo-refresh branch February 27, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibodrov ibodrov ibodrov approved these changes

@dankle dankle dankle approved these changes

@mtkunkel mtkunkel mtkunkel approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benbroadaway @ibodrov @dankle @mtkunkel