concord-server: invalidate session on failed login #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brig
previously approved these changes
Jan 3, 2024
brig
approved these changes
Jan 15, 2024
ibodrov
added a commit
that referenced
this pull request
Apr 29, 2024
This effectively reverts #859. The change broke redirect after login when the authentication times out (e.g. OIDC login). Unfortunaly, pax4j stores the "from" parameter in the session so we need it alive when we redirect the user between the app and the auth provider. We might want to use a separate cookie or have a way to differentiate between onLoginFailure reasons when we make a decision to invalidate the session.
ibodrov
added a commit
that referenced
this pull request
Apr 29, 2024
This effectively reverts #859. The change broke redirect after login when the authentication times out (e.g. OIDC login). Unfortunaly, pax4j stores the "from" parameter in the session so we need it alive when we redirect the user between the app and the auth provider. We might want to use a separate cookie or have a way to differentiate between onLoginFailure reasons when we make a decision to invalidate the session.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, 902e5f5 is not enough -- we need to invalidate the session as well.