Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime-v2: mock tasks #754

Merged
merged 3 commits into from
Apr 1, 2024
Merged

runtime-v2: mock tasks #754

merged 3 commits into from
Apr 1, 2024

Conversation

brig
Copy link
Contributor

@brig brig commented May 16, 2023

Experimental feature, but might be useful :)

@brig brig requested a review from a team May 16, 2023 11:16
@ibodrov
Copy link
Collaborator

ibodrov commented Oct 16, 2023

Let's decide if we also need assert-like facilities here as well. Mocking tasks is usually a one part of a bigger problem -- flow unit testing. Perhaps we need to provide a more complete "concord-testing" plugin?

ibodrov
ibodrov approved these changes Apr 1, 2024
View reviewed changes
Copy link
Collaborator

@ibodrov ibodrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asserts can be added later if needed. This LGTM as it is now.

@ibodrov ibodrov merged commit b8fa4b2 into master Apr 1, 2024
2 checks passed
@ibodrov ibodrov deleted the brig/task-mocks branch April 1, 2024 15:15
@brig
Copy link
Contributor Author

brig commented Nov 1, 2024

docs: walmartlabs/concord-website#168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibodrov ibodrov ibodrov approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brig @ibodrov