Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime-v2: hide stack trace and log location for paralle exception #1081

Merged
merged 5 commits into from
Feb 17, 2025

Conversation

brig
Copy link
Contributor

@brig brig commented Feb 12, 2025

before:

18:59:33 [ERROR] (concord.yml): Error @ line: 9, col: 7. Parallel execution errors: 
com.walmartlabs.concord.svm.ParallelExecutionException: Parallel execution errors: 
Task not found: 'userDefinedExceptionTask'

Task not found: 'userDefinedExceptionTask'

	at com.walmartlabs.concord.runtime.v2.runner.vm.JoinCommand.execute(JoinCommand.java:92)
	at com.walmartlabs.concord.runtime.v2.runner.vm.StepCommand.lambda$executeWithContext$1(StepCommand.java:97)
	at com.walmartlabs.concord.runtime.v2.runner.tasks.ContextProvider.withContext(ContextProvider.java:49)
	...9 more

after:

18:59:33 [ERROR] (concord.yml): Error @ line: 9, col: 7. Parallel execution errors: 
(concord.yml): Error @ line: 16, col: 7, thread: 2: Parallel execution errors: 
(concord.yml): Error @ line: 17, col: 11, thread: 3: Task not found: 'userDefinedExceptionTask'
(concord.yml): Error @ line: 17, col: 11, thread: 5: Task not found: 'userDefinedExceptionTask'

concord.yaml:

flows:
  default:
    - call: inner                                                # line: 9
      loop:
        items: [1, 2]
        mode: parallel
        parallelism: 2

  inner:
    - parallel:                                                    # line: 16
        - task: "userDefinedExceptionTask"    # line: 17
        - log: "OK"

@brig brig added the wip Work in progress, do not merge label Feb 12, 2025
@brig brig force-pushed the brig/v2-parallel-exception-logs branch from 55405fa to cd19e05 Compare February 13, 2025 06:06
@brig brig removed the wip Work in progress, do not merge label Feb 13, 2025
@brig brig requested a review from a team February 13, 2025 17:36
@brig brig force-pushed the brig/v2-parallel-exception-logs branch from 1db0338 to 92882c1 Compare February 13, 2025 19:16
@ibodrov ibodrov merged commit 34cbc1d into master Feb 17, 2025
4 checks passed
@ibodrov ibodrov deleted the brig/v2-parallel-exception-logs branch February 17, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants