Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project: do not log into Docker in check runs started in forks (another attempt) #1079

Merged
merged 1 commit into from
Feb 9, 2025

Conversation

ibodrov
Copy link
Collaborator

@ibodrov ibodrov commented Feb 9, 2025

Checking github.repository_owner is not enough. IIUC, it always points at the repository in the context of which the current GHA check is running.

Let's try github.event.pull_request.head.repo.full_name instead.

…er attempt)

Checking github.repository_owner is not enough. IIUC, it always points
at the repository in the context of which the current GHA check is
running.

Let's try `github.event.pull_request.head.repo.full_name` instead.
@ibodrov ibodrov requested a review from a team February 9, 2025 21:38
@ibodrov ibodrov merged commit 972d7e2 into master Feb 9, 2025
4 checks passed
@ibodrov ibodrov deleted the ib/docker-login-again branch February 9, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants