From 0b39f10aaca5d5d049d290a761a418e2d9907647 Mon Sep 17 00:00:00 2001 From: Ivan Bodrov Date: Sat, 4 May 2024 18:27:08 -0400 Subject: [PATCH 1/2] concord-server: fix Jetty metrics (#899) Upgrade Dropwizard Metrics and fix Jetty session metrics exporter for Jetty 12 compatibility. --- .../concord/server/metrics/JettySessionMetricsModule.java | 2 +- server/plugins/noderoster/impl/pom.xml | 4 ---- targetplatform/pom.xml | 6 +++--- 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/server/impl/src/main/java/com/walmartlabs/concord/server/metrics/JettySessionMetricsModule.java b/server/impl/src/main/java/com/walmartlabs/concord/server/metrics/JettySessionMetricsModule.java index 8be40f54d9..d6765d2a98 100644 --- a/server/impl/src/main/java/com/walmartlabs/concord/server/metrics/JettySessionMetricsModule.java +++ b/server/impl/src/main/java/com/walmartlabs/concord/server/metrics/JettySessionMetricsModule.java @@ -63,7 +63,7 @@ public Gauge gauge() { private static Object getAttribute(String attribute) { try { MBeanServer mBeans = ManagementFactory.getPlatformMBeanServer(); - return mBeans.getAttribute(new ObjectName("org.eclipse.jetty.server.session:context=ROOT,id=0,type=defaultsessioncache"), attribute); + return mBeans.getAttribute(new ObjectName("org.eclipse.jetty.session:context=ROOT,id=0,type=defaultsessioncache"), attribute); } catch (Exception e) { throw new RuntimeException(e); } diff --git a/server/plugins/noderoster/impl/pom.xml b/server/plugins/noderoster/impl/pom.xml index 9abf723309..ede639b861 100644 --- a/server/plugins/noderoster/impl/pom.xml +++ b/server/plugins/noderoster/impl/pom.xml @@ -158,10 +158,6 @@ io.dropwizard.metrics metrics-core - - io.dropwizard.metrics - metrics-jetty9 - diff --git a/targetplatform/pom.xml b/targetplatform/pom.xml index a27808181e..d2ed64604b 100644 --- a/targetplatform/pom.xml +++ b/targetplatform/pom.xml @@ -102,7 +102,7 @@ 3.8.4 1.7.3 0.0.4 - 4.2.13 + 4.2.25 4.9.0 0.9.10 8.8 @@ -118,7 +118,7 @@ 1.10.1 2.3.2 0.9.0.M2 - 2.0.10 + 2.0.11 2.2 2.8.0 1.0.2 @@ -455,7 +455,7 @@ io.dropwizard.metrics - metrics-jetty9 + metrics-jetty12 ${metrics.version} From 228d9cc0e3afb2cea96ba1aa83edde2c41179523 Mon Sep 17 00:00:00 2001 From: Ivan Bodrov Date: Sun, 5 May 2024 10:02:50 -0400 Subject: [PATCH 2/2] concord-server: add some missing GHA event types (#900) --- .../concord/server/events/github/Payload.java | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/server/impl/src/main/java/com/walmartlabs/concord/server/events/github/Payload.java b/server/impl/src/main/java/com/walmartlabs/concord/server/events/github/Payload.java index ecbe61379b..64f7c7cddb 100644 --- a/server/impl/src/main/java/com/walmartlabs/concord/server/events/github/Payload.java +++ b/server/impl/src/main/java/com/walmartlabs/concord/server/events/github/Payload.java @@ -35,7 +35,8 @@ public class Payload { /** * List of supported repository-level events. */ - private static final Set REPOSITORY_EVENTS = asSet( + private static final Set REPOSITORY_EVENTS = Set.of( + "check_run", "commit_comment", "create", "delete", @@ -49,15 +50,18 @@ public class Payload { "pull_request_review_comment", "push", "release", + "repository", + "status", "team", "team_add", - "repository" - ); + "workflow_job", + "workflow_run" + ); /** * List of supported organization-level events. */ - private static final Set ORGANIZATION_EVENTS = asSet( + private static final Set ORGANIZATION_EVENTS = Set.of( "membership", "organization", "org_block" @@ -227,10 +231,6 @@ private static String getBranchPullRequest(Map event) { return MapUtils.getString(base, "ref"); } - private static Set asSet(String... as) { - return Collections.unmodifiableSet(new HashSet<>(Arrays.asList(as))); - } - @Override public String toString() { return "Payload{" +