Skip to content

Commit

Permalink
concord-console2: upgrade node version
Browse files Browse the repository at this point in the history
  • Loading branch information
ibodrov committed Apr 12, 2024
1 parent 8ff13c3 commit 65fb046
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 8 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ Dependencies:
- [Java 17](https://adoptium.net/)
- [Docker Community Edition](https://www.docker.com/community-edition)
- [Docker Buildx](https://docs.docker.com/build/buildx/install/)
- (Optional) [NodeJS and NPM](https://nodejs.org/en/download/) (Node 16 or greater)
- (Optional) [NodeJS and NPM](https://nodejs.org/en/download/) (Node 20 or greater)

```shell
git clone https://github.com/walmartlabs/concord.git
Expand Down
4 changes: 2 additions & 2 deletions console2/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ Uses https://github.com/facebook/create-react-app/ as the boilerplate.

## Prerequisites

- Node 10 or greater, available in `$PATH`;
- Java 8, available in `$PATH`. Necessary only to build the package.
- Node 20 or greater, available in `$PATH`;
- Java 17, available in `$PATH`. Necessary only to build the package.

## Dependencies

Expand Down
1 change: 1 addition & 0 deletions console2/npm.sh
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#!/usr/bin/env bash
# run a local version of node installed by Maven
export SET NODE_OPTIONS=--openssl-legacy-provider
./target/node/node ./target/node/node_modules/npm/bin/npm-cli.js "$@"
6 changes: 3 additions & 3 deletions console2/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,10 @@
"url-search-params-polyfill": "8.1.1"
},
"scripts": {
"start": "react-scripts start",
"build": "./npm.sh run hack:remove-sui-css-dep && react-scripts build",
"start": "export SET NODE_OPTIONS=--openssl-legacy-provider && react-scripts start",
"build": "export SET NODE_OPTIONS=--openssl-legacy-provider && ./npm.sh run hack:remove-sui-css-dep && react-scripts build",
"hack:remove-sui-css-dep": "shx --silent sed -i @import /*import node_modules/semantic-ui-css/semantic.min.css > /dev/null 2>&1",
"dev": "babel-node --presets es2015 scripts/devServer.js",
"dev": "export SET NODE_OPTIONS=--openssl-legacy-provider && babel-node --presets es2015 scripts/devServer.js",
"test": "react-scripts test",
"test:watch": "./npm.sh test --watch",
"pretty": "prettier --tab-width 4 --print-width 100 --single-quote --jsx-bracket-same-line --arrow-parens 'always' parser 'typescript' --write 'src/**/*.{ts,tsx}'"
Expand Down
2 changes: 1 addition & 1 deletion console2/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
</goals>
<configuration>
<skip>${skipNpm}</skip>
<arguments>${npm.installCmd}</arguments>
<arguments>${npm.installCmd} --legacy-peer-deps</arguments>
</configuration>
</execution>
<execution>
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
<junit.version>5.8.2</junit.version>
<liquibase.version>3.5.1
</liquibase.version> <!-- the newer versions (up to 3.5.3) have incorrect mappings for PG's blob/bytea -->
<node.version>16.13.1</node.version>
<node.version>20.12.2</node.version>
<frontend.plugin.version>1.12.0</frontend.plugin.version>

<jdk.version>17</jdk.version>
Expand Down

0 comments on commit 65fb046

Please sign in to comment.