-
Notifications
You must be signed in to change notification settings - Fork 107
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
runtime-v2: hide stack trace and log location for ParallelExecutionEx…
…ception (#1081)
- Loading branch information
Showing
18 changed files
with
291 additions
and
35 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
...walmartlabs/concord/runtime/v2/runner/logExceptionTests/fromParallelParallel/concord.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| flows: | ||
| default: | ||
| - call: inner | ||
| loop: | ||
| items: [1, 2] | ||
| mode: parallel | ||
| parallelism: 2 | ||
|
|
||
| inner: | ||
| - parallel: | ||
| - task: "userDefinedExceptionTask" | ||
| - log: "OK" |
6 changes: 6 additions & 0 deletions
6
...urces/com/walmartlabs/concord/runtime/v2/runner/logExceptionTests/fromScript/concord.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| flows: | ||
| default: | ||
| - script: "js" | ||
| body: | | ||
| log.info('ready...'); | ||
| throw new java.lang.RuntimeException("Something went wrong"); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
109 changes: 109 additions & 0 deletions
109
...rc/main/java/com/walmartlabs/concord/runtime/v2/runner/vm/ParallelExecutionException.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| package com.walmartlabs.concord.runtime.v2.runner.vm; | ||
|
|
||
| /*- | ||
| * ***** | ||
| * Concord | ||
| * ----- | ||
| * Copyright (C) 2017 - 2023 Walmart Inc. | ||
| * ----- | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * ===== | ||
| */ | ||
|
|
||
| import com.walmartlabs.concord.runtime.v2.model.Location; | ||
| import com.walmartlabs.concord.svm.ThreadError; | ||
|
|
||
| import java.io.PrintStream; | ||
| import java.io.PrintWriter; | ||
| import java.io.Serial; | ||
| import java.io.StringWriter; | ||
| import java.util.ArrayList; | ||
| import java.util.Collection; | ||
| import java.util.List; | ||
| import java.util.stream.Collectors; | ||
|
|
||
| /** | ||
| * An exception that is thrown when multiple exceptions are thrown | ||
| * in {@code parallel} blocks. | ||
| */ | ||
| public class ParallelExecutionException extends RuntimeException { | ||
|
|
||
| @Serial | ||
| private static final long serialVersionUID = 1L; | ||
|
|
||
| private static final int MAX_STACK_TRACE_ELEMENTS = 3; | ||
| private final List<ThreadError> exceptions; | ||
|
|
||
| public ParallelExecutionException(Collection<ThreadError> causes) { | ||
| super("Parallel execution errors: \n" + toMessage(causes)); | ||
| this.exceptions = new ArrayList<>(causes); | ||
| } | ||
|
|
||
| public List<Exception> getExceptions() { | ||
| return exceptions.stream().map(ThreadError::exception).toList(); | ||
| } | ||
|
|
||
| private static String toMessage(Collection<ThreadError> causes) { | ||
| return causes.stream() | ||
| .map(ParallelExecutionException::stacktraceToString) | ||
| .collect(Collectors.joining("\n")); | ||
| } | ||
|
|
||
| @Override | ||
| public void printStackTrace(PrintStream s) { | ||
| s.println(getMessage()); | ||
| } | ||
|
|
||
| @Override | ||
| public void printStackTrace(PrintWriter s) { | ||
| s.println(getMessage()); | ||
| } | ||
|
|
||
| private static String stacktraceToString(ThreadError e) { | ||
| StringWriter sw = new StringWriter(); | ||
| sw.append(toString(e)); | ||
|
|
||
| StackTraceElement[] elements = e.getStackTrace(); | ||
| if (elements.length > 0) { | ||
| sw.append("\n"); | ||
| } | ||
|
|
||
| int maxElements = Math.min(elements.length, MAX_STACK_TRACE_ELEMENTS); | ||
| for (int i = 0; i < maxElements; i++) { | ||
| StackTraceElement element = elements[i]; | ||
| sw.append("\tat ").append(element.toString()).append("\n"); | ||
| } | ||
| if (maxElements != elements.length) { | ||
| sw.append("\t...").append(String.valueOf(elements.length - maxElements)).append(" more\n"); | ||
| } | ||
| return sw.toString(); | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return getMessage(); | ||
| } | ||
|
|
||
| @Override | ||
| public StackTraceElement[] getStackTrace() { | ||
| return new StackTraceElement[0]; | ||
| } | ||
|
|
||
| private static String toString(ThreadError threadError) { | ||
| String prefix = ""; | ||
| if (threadError.cmd() instanceof StepCommand<?> sc) { | ||
| prefix = Location.toErrorPrefix(sc.getStep().getLocation()) + ", "; | ||
| } | ||
| return prefix + "thread: " + threadError.threadId().id() + ": " + threadError.exception(); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.