server: fix json serialization of UserActivityResponse (#885)

walmartlabs · Apr 3, 2024 · 09fde47 · 09fde47
1 parent ced5874
commit 09fde47
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 16 deletions.
diff --git a/server/impl/src/main/java/com/walmartlabs/concord/server/console/UserActivityResourceV2.java b/server/impl/src/main/java/com/walmartlabs/concord/server/console/UserActivityResourceV2.java
@@ -57,6 +57,8 @@ public UserActivityResponse activity(@QueryParam("maxOwnProcesses") @DefaultValu
                 .build();
         List<ProcessEntry> lastProcesses = processDao.list(filter);
 
-        return new UserActivityResponse(lastProcesses);
+        return ImmutableUserActivityResponse.builder()
+                .processes(lastProcesses)
+                .build();
     }
 }
diff --git a/server/impl/src/main/java/com/walmartlabs/concord/server/console/UserActivityResponse.java b/server/impl/src/main/java/com/walmartlabs/concord/server/console/UserActivityResponse.java
@@ -20,30 +20,26 @@
  * =====
  */
 
-import com.fasterxml.jackson.annotation.JsonCreator;
 import com.fasterxml.jackson.annotation.JsonInclude;
 import com.fasterxml.jackson.annotation.JsonInclude.Include;
-import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.databind.annotation.JsonDeserialize;
+import com.fasterxml.jackson.databind.annotation.JsonSerialize;
 import com.walmartlabs.concord.server.process.ProcessEntry;
+import org.immutables.value.Value;
 
-import java.io.Serial;
 import java.io.Serializable;
 import java.util.List;
 
+@Value.Immutable
 @JsonInclude(Include.NON_EMPTY)
-public final class UserActivityResponse implements Serializable {
+@JsonSerialize(as = ImmutableUserActivityResponse.class)
+@JsonDeserialize(as = ImmutableUserActivityResponse.class)
+public interface UserActivityResponse extends Serializable {
 
-    @Serial
-    private static final long serialVersionUID = 1L;
+    long serialVersionUID = 1L;
 
-    private final List<ProcessEntry> processes;
-
-    @JsonCreator
-    public UserActivityResponse(@JsonProperty("processes") List<ProcessEntry> processes) {
-        this.processes = processes;
-    }
-
-    public List<ProcessEntry> processes() {
-        return processes;
+    @Value.Default
+    default List<ProcessEntry> processes() {
+        return List.of();
     }
 }