Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix flush-notes #78

Open
weboko opened this issue Jul 23, 2024 · 1 comment
Open

bug: fix flush-notes #78

weboko opened this issue Jul 23, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@weboko
Copy link
Collaborator

weboko commented Jul 23, 2024

Problem

Currently flush-notes is not working due to problem with NextJS paths.

image

Solution

Update deploy step so that it copies out directory of flush-notes with _next, currently it doesn't in

sh "cp -r out/. ${dest}"

image

Then we should fix paths in the output so that it loads js files and others from subfolder in lab.waku.org/flush-notes/_next.
I couldn't find a way to do this through next.config.js so we should use following: vercel/next.js#45422 (comment)

image

Notes

@weboko weboko added the bug Something isn't working label Jul 23, 2024
@weboko weboko added this to Waku Jul 23, 2024
@weboko weboko moved this to Triage in Waku Jul 23, 2024
@weboko weboko moved this from Triage to To Do in Waku Jul 23, 2024
@weboko
Copy link
Collaborator Author

weboko commented Aug 13, 2024

  • use telemetry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: To Do
Development

No branches or pull requests

1 participant