Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support new response format & feature #6

Closed
VictoriqueMoe opened this issue Apr 2, 2024 · 2 comments · Fixed by #7
Closed

support new response format & feature #6

VictoriqueMoe opened this issue Apr 2, 2024 · 2 comments · Fixed by #7
Assignees
Labels
enhancement New feature or request

Comments

@VictoriqueMoe
Copy link
Member

there are 2 changes to be made.

First

the first is the WaifuResponse has moved protected and hideFilename into it's own settings object that looks as followes:

image

You can check the swagger schema for this change here: https://waifuvault.moe/api-docs/

image

this object can not be null and will ALWAYS contain the values inside of it

Second

The second change is in the upload query parameters, there is a new optional boolean called one_time_download. you can see this reflected here:
image

@VictoriqueMoe VictoriqueMoe added the enhancement New feature or request label Apr 2, 2024
@ernestmarcinko
Copy link
Collaborator

I will rather smell some shoes

@VictoriqueMoe
Copy link
Member Author

I will rather smell some shoes

DO IT

ernestmarcinko added a commit that referenced this issue Apr 3, 2024
@ernestmarcinko ernestmarcinko linked a pull request Apr 3, 2024 that will close this issue
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants