Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not expose unknown usernameFragment to stats #789

Open
fippo opened this issue Oct 28, 2024 · 2 comments · May be fixed by #795
Open

Do not expose unknown usernameFragment to stats #789

fippo opened this issue Oct 28, 2024 · 2 comments · May be fixed by #795

Comments

@fippo
Copy link
Contributor

fippo commented Oct 28, 2024

webtorrent/webtorrent#288 (comment)
points out that the remote ICE usernameFragment (added in #611) can act as a sidechannel (and while it is authenticated, it lacks encryption).

In theory one can skip signaling in one direction that way. We should only expose the remote usernameFragment on prflx candidates if it is known by signaling.
@alvestrand
Copy link
Contributor

I think this is an obvious fix, and should be marked "ready for PR".

fippo added a commit to fippo/webrtc-stats that referenced this issue Oct 29, 2024
@fippo
do not expose unsignalled remote usernameFragments in prflx remote-ca…
7ecdfdb 
…ndidate

fixes w3c#789
@fippo
Copy link
Contributor Author

fippo commented Jan 3, 2025

Do we need to put it on the WG agenda?

fippo added a commit to fippo/webrtc-stats that referenced this issue Feb 6, 2025
@fippo
Do not expose unknown usernameFragment to stats
ceee825 
fixes w3c#789
fippo added a commit to fippo/webrtc-stats that referenced this issue Feb 6, 2025
@fippo
Do not expose unknown usernameFragment to stats
f747146 
fixes w3c#789
@fippo fippo linked a pull request Feb 6, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not expose unknown usernameFragment to stats fippo/webrtc-stats
2 participants
@fippo @alvestrand