Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Redirect" unknown hashes to a "page not found" like view for feedback #126

Open
rvantonisse opened this issue Apr 25, 2019 · 5 comments
Open
Assignees
Labels
bug Something isn't working enhancement New feature or request Functionality Issues related to functionality Generator Generator script
Milestone

Comments

@rvantonisse
Copy link
Collaborator

When using hashed urls without "create" or "preview" in it, the generator looks like it is not functioning (blank page).

Redirect all other hashed urls to a "Page not found" view

@rvantonisse rvantonisse added enhancement New feature or request Functionality Issues related to functionality labels Apr 25, 2019
@rvantonisse rvantonisse self-assigned this Apr 25, 2019
@yatil
Copy link
Contributor

yatil commented Apr 26, 2019

FWIW I think I would prefer to just load the main page as without hash instead – that is what happens on ”normal”, not JS-enhanced web pages when a fragment is not found.

@nitedog nitedog added bug Something isn't working Generator Generator script labels Jan 27, 2021
@nitedog nitedog added this to the First Release milestone Jan 27, 2021
@basdebruin
Copy link
Contributor

Do we still want to add a "Page not found" view to the generator page? Right now the behaviour is in line with what @yatil proposed: whenever an unfamiliar hash is used, it defaults to the "Create Statement" page.
In my opinion this is desired behaviour and this issue can be closed.

@nitedog
Copy link
Contributor

nitedog commented Mar 14, 2021

It works partially. Here are directions to recreate the bug:

  1. Open new browser window with address https://www.w3.org/WAI/planning/statements/generator/#test
  2. It correctly defaults to "Create Statement" https://www.w3.org/WAI/planning/statements/generator/#create
  3. In the same session, change the hash "#create" to "#test" and press enter (not hard refresh)
  4. Bug: it displays empty "Generate an Accessibility Statement" page

Is this easy to fix (recognize that "Preview your accessibility statement" button was not pressed)?

@nitedog
Copy link
Contributor

nitedog commented Mar 14, 2021

Another version of that bug:

  1. Open new browser with overview page https://www.w3.org/WAI/planning/statements/
  2. Select "Generator Tool" from the left navigation https://www.w3.org/WAI/planning/statements/generator/#create
  3. It correctly shows "Create Statement" by redirecting to https://www.w3.org/WAI/planning/statements/generator/#create
  4. Press back button in the browser
  5. Bug: it displays empty "Generate an Accessibility Statement" page

basdebruin added a commit to AccessibilityNL/wai-statements that referenced this issue Mar 17, 2021
@basdebruin
Copy link
Contributor

This issue should now be fixed, pushed as part of PR #150

The issue only seemed to appear on chrome, not safari and also affected the "Skip to Content" button at the top of the page.
The generator now defaults to the main "create" page whenever the hash is changed to something unfamiliar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request Functionality Issues related to functionality Generator Generator script
Projects
None yet
Development

No branches or pull requests

4 participants